Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ReviewSpendingLimitTx to use SignOrExecuteForm #4814

Open
katspaugh opened this issue Jan 22, 2025 · 0 comments
Open

Refactor ReviewSpendingLimitTx to use SignOrExecuteForm #4814

katspaugh opened this issue Jan 22, 2025 · 0 comments
Labels
tech debt

Comments

@katspaugh
Copy link
Member

katspaugh commented Jan 22, 2025 •
edited
Loading

It's currently using its own gas estimation and execution logic and lacks features like Relaying.

For uniform execution logic, Spending Limit txs should be a type of ExecuteForm like ExecuteThroughRoleForm.

Also change the "Submit" button to "Execute".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katspaugh