Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Orgs] Implement sign in button #4965

Open
usame-algan opened this issue Feb 12, 2025 · 1 comment
Open

[Orgs] Implement sign in button #4965

usame-algan opened this issue Feb 12, 2025 · 1 comment
Assignees
Milestone

Comments

@usame-algan
Copy link
Member

Links

Epic on Notion: https://www.notion.so/safe-global/Org-onboarding-flow-1208180fe57380078591f5380a0c5d2a

What must be done

  • Adjust the current sign in button to match the design of the continue with wallet button
  • Handle disconnected wallet fallback

Designs/sketches

Image

How to test it

  • If the user has no connected wallet they should not sign in but instead connect first
  • If they are connected the sign in button should look like the continue with wallet button
@katspaugh katspaugh added this to the 1.51.0 milestone Feb 12, 2025
@jmealy jmealy self-assigned this Feb 26, 2025
@francovenica
Copy link
Contributor

@jmealy

Question. This ticket says we should handle the disconnect (which currently works in the RC), but shouldn't also handle changing the wallet's owner?
Currently if you switch owners in your MM extension, you are still logged in as previous user. You are forced to disconnect and then reconnect with already the user you want selected in MM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants