gh-40242: cleaning coding/ using cython-lint

clean pyx files in coding folder, following suggestions of cython-lint

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: #40242
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert

Author: Release Manager

build/pkgs/configure/checksums.ini

@@ -1,3 +1,3 @@
 tarball=configure-VERSION.tar.gz
-sha1=71e76e4d1c6e4c3c6f225a6dbcee0055bca54192
-sha256=ba4fb20c79af60e61ca4656cbddb6dfb5d3cee545e751dbb9e49243d345db6db
+sha1=33d22817472241d1fe2fff96650d316a2994abc8
+sha256=710b5de4286e235fa6a85f512f05a4aef324a94bf06af654ffe3fadeeb8f439e

build/pkgs/configure/package-version.txt

@@ -1 +1 @@
-5379f2e776e9b8f79a8a2e37f8e407f52e8d26cd
+6d8ba06374c4478e7f64a29482e1b6eadc56027b

src/sage/coding/ag_code_decoders.pyx

@@ -604,15 +604,16 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
 
         if Q.degree() > 1:
             circuit = EvaluationAGCodeDecoder_K_extension(code._pls, code._G, Q,
-                                                           verbose=verbose)
+                                                          verbose=verbose)
         else:
             circuit = EvaluationAGCodeDecoder_K(code._pls, code._G, Q,
-                                                 verbose=verbose)
+                                                verbose=verbose)
 
         if basis is None:
             basis = code._basis_functions
 
-        C = matrix([circuit.decode(vector(K, [f.evaluate(p) for p in code._pls]))
+        C = matrix([circuit.decode(vector(K,
+                                          [f.evaluate(p) for p in code._pls]))
                     for f in basis])
 
         self._extension = Q.degree() > 1
@@ -647,7 +648,7 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
         """
         return hash((self.code(), self._Q))
 
-    def __eq__(self, other):
+    def __eq__(self, other) -> bool:
         """
         Check whether ``other`` equals ``self``.
 
@@ -677,7 +678,7 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
         return (self.code() == other.code() and self._Q == other._Q
                 and self._basis == other._basis)
 
-    def _repr_(self):
+    def _repr_(self) -> str:
         r"""
         Return the string representation of ``self``.
 
@@ -699,7 +700,7 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
         """
         return "Unique decoder for {}".format(self.code())
 
-    def _latex_(self):
+    def _latex_(self) -> str:
         r"""
         Return the latex representation of ``self``.
 
@@ -757,13 +758,13 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
         else:
             return circuit.encode(vector(K, message) * C)
 
-    def _decode(self, vector, **kwargs):
+    def _decode(self, vect, **kwargs):
         r"""
-        Return the message decoded from ``vector``.
+        Return the message decoded from the vector ``vect``.
 
         INPUT:
 
-        - ``vector`` -- a vector to be decoded to a message
+        - ``vect`` -- a vector to be decoded to a message
 
         TESTS::
 
@@ -787,10 +788,10 @@ class EvaluationAGCodeUniqueDecoder(Decoder):
         circuit = self._circuit
 
         if self._extension:
-            internal_message = circuit.decode(circuit._lift(vector), **kwargs) * Cinv
+            internal_message = circuit.decode(circuit._lift(vect), **kwargs) * Cinv
             return circuit._pull_back(internal_message)
-        else:
-            return circuit.decode(vector, **kwargs) * Cinv
+
+        return circuit.decode(vect, **kwargs) * Cinv
 
     def connected_encoder(self, *args, **kwargs):
         r"""
@@ -1011,10 +1012,10 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
 
         if Q.degree() > 1:
             circuit = DifferentialAGCodeDecoder_K_extension(code._pls, code._G, Q,
-                                                             verbose=verbose)
+                                                            verbose=verbose)
         else:
             circuit = DifferentialAGCodeDecoder_K(code._pls, code._G, Q,
-                                                   verbose=verbose)
+                                                  verbose=verbose)
 
         if basis is None:
             basis = code._basis_differentials
@@ -1054,7 +1055,7 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
         """
         return hash((self.code(), self._Q))
 
-    def __eq__(self, other):
+    def __eq__(self, other) -> bool:
         """
         Check whether ``other`` equals ``self``.
 
@@ -1084,7 +1085,7 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
         return (self.code() == other.code() and self._Q == other._Q
                 and self._basis == other._basis)
 
-    def _repr_(self):
+    def _repr_(self) -> str:
         r"""
         Return the string representation of ``self``.
 
@@ -1106,7 +1107,7 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
         """
         return "Unique decoder for {}".format(self.code())
 
-    def _latex_(self):
+    def _latex_(self) -> str:
         r"""
         Return the latex representation of ``self``.
 
@@ -1164,13 +1165,13 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
         else:
             return circuit.encode(vector(K, message) * C)
 
-    def _decode(self, vector, **kwargs):
+    def _decode(self, vect, **kwargs):
         r"""
-        Return the message decoded from ``vector``.
+        Return the message decoded from the vector ``vect``.
 
         INPUT:
 
-        - ``vector`` -- a vector to be decoded to a message
+        - ``vect`` -- a vector to be decoded to a message
 
         TESTS::
 
@@ -1194,10 +1195,10 @@ class DifferentialAGCodeUniqueDecoder(Decoder):
         circuit = self._circuit
 
         if self._extension:
-            internal_message = circuit.decode(circuit._lift(vector), **kwargs) * Cinv
+            internal_message = circuit.decode(circuit._lift(vect), **kwargs) * Cinv
             return circuit._pull_back(internal_message)
-        else:
-            return circuit.decode(vector, **kwargs) * Cinv
+
+        return circuit.decode(vect, **kwargs) * Cinv
 
     def connected_encoder(self, *args, **kwargs):
         r"""
@@ -1423,7 +1424,7 @@ cdef class Decoder_K():
             This modified the ``vec`` input.
         """
         cdef Py_ssize_t j, m
-        cdef list a, d, s
+        cdef list a, s
         cdef FreeModuleElement temp
         cdef Polynomial c
 
@@ -1507,7 +1508,6 @@ cdef class Decoder_K():
         coeff_mat = self.coeff_mat
 
         cdef list message_index = self.message_index
-        cdef list code_basis = self.code_basis
 
         cdef int s0 = self.s0
         cdef int tau = self.tau
@@ -1858,7 +1858,7 @@ cdef class EvaluationAGCodeDecoder_K(Decoder_K):
             sage: circuit = EvaluationAGCodeDecoder_K(D, G, Q)   # long time
             sage: TestSuite(circuit).run(skip='_test_pickling')  # long time
         """
-        cdef int i, j, s, s0, sk, si, n, r, d, num
+        cdef int i, j, s, s0, sk, si, n, r, d
         cdef int code_length, genus, gamma, dLO, tau
         cdef list gaps, dR, yR, dRbar, yRbar, evyRbar, nus, mul_mat
         cdef list message_index, code_basis
@@ -2113,7 +2113,7 @@ cdef class DifferentialAGCodeDecoder_K(Decoder_K):
             sage: circuit = DifferentialAGCodeDecoder_K(D, G, Q)  # long time
             sage: TestSuite(circuit).run(skip='_test_pickling')   # long time
         """
-        cdef int i, j, s, s0, sk, si, n, r, d, num
+        cdef int i, j, s, s0, sk, si, n, r, d
         cdef int code_length, genus, gamma, dLO, tau
         cdef list gaps, dR, yR, dWbar, wWbar, reswWbar, nus, mul_mat
         cdef list message_index, code_basis
@@ -2387,7 +2387,7 @@ cdef class Decoder_K_extension():
             # construct constant field extension F_ext of F
             def_poly = F.polynomial().base_extend(F_ext_base)
             F_ext = F_ext_base.extension(def_poly, names=def_poly.variable_name())
-        else: # rational function field
+        else:  # rational function field
             F_ext = F_ext_base
 
         O_ext = F_ext.maximal_order()

src/sage/coding/binary_code.pxd

@@ -67,12 +67,12 @@ cdef class PartitionStack:
     cdef int ncols
     cdef int radix
     cdef int flag
-    cdef int *col_degs   #
-    cdef int *col_counts #
-    cdef int *col_output #
-    cdef int *wd_degs    #
-    cdef int *wd_counts  # These are just for scratch space...
-    cdef int *wd_output  #
+    cdef int *col_degs    #
+    cdef int *col_counts  #
+    cdef int *col_output  #
+    cdef int *wd_degs     #
+    cdef int *wd_counts   # These are just for scratch space...
+    cdef int *wd_output   #
 
     cdef int is_discrete(self, int) noexcept
     cdef int num_cells(self, int) noexcept