Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of direct org.jruby.embed.ScriptingContainer use #11

Open
dmikurube opened this issue Aug 29, 2019 · 0 comments
Open

Get rid of direct org.jruby.embed.ScriptingContainer use #11

dmikurube opened this issue Aug 29, 2019 · 0 comments

Comments

@dmikurube
Copy link

The Embulk core is going to make JRuby optional in next major versions (expected to be v0.10). Then, org.jruby.embed.ScriptingContainer will be no longer available.

// Parse like "table_%Y_%m"(include pattern or not) format using Java is difficult. So use jRuby.
public String generateTableName(String tableName)
{
ScriptingContainer jruby = new ScriptingContainer();
return jruby.runScriptlet("Time.now.strftime('" + tableName + "')").toString();
}

We'll need to consider an alternative against this...

xuantuan58 pushed a commit to xuantuan58/embulk-output-dynamodb that referenced this issue Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant