diff --git a/src/main/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationService.java b/src/main/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationService.java index 1d8027b..d00351f 100644 --- a/src/main/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationService.java +++ b/src/main/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationService.java @@ -346,9 +346,7 @@ public final static ImageOptimizationService createInstance(final String logger.debug("Current local directory is: {}", new File(".").getCanonicalPath()); } - final File tmpDir = File.createTempFile(ImageOptimizationService.class.getName(), ""); - tmpDir.delete(); - tmpDir.mkdir(); + final File tmpDir = Files.createTempDirectory(ImageOptimizationService.class.getName()).toFile(); return new ImageOptimizationService<>(tmpDir, new File(pathToBinaryProgramsForImageOptimizationDirectory).getCanonicalFile(), timeoutInSeconds); } diff --git a/src/test/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationServiceTest.java b/src/test/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationServiceTest.java index 6768a5e..f533b8c 100644 --- a/src/test/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationServiceTest.java +++ b/src/test/java/com/salesforce/perfeng/uiperf/imageoptimization/service/ImageOptimizationServiceTest.java @@ -44,6 +44,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; @@ -91,9 +92,7 @@ public class ImageOptimizationServiceTest { */ @BeforeEach public void setUp() throws IOException { - final File tmpDir = File.createTempFile(ImageOptimizationServiceTest.class.getName(), ""); - tmpDir.delete(); - tmpDir.mkdir(); + final File tmpDir = Files.createTempDirectory(ImageOptimizationServiceTest.class.getName()).toFile(); tmpDir.deleteOnExit(); imageOptimizationService = new ImageOptimizationService<>(tmpDir, new File(DEFAULT_BINARY_APP_LOCATION)); @@ -120,9 +119,7 @@ public void testImageOptimizationService() throws IOException { actualException = assertThrows(IllegalArgumentException.class, () -> new ImageOptimizationService<>(file, new File(DEFAULT_BINARY_APP_LOCATION))); assertThat(actualException.getMessage(), matchesRegex("The passed in tmpWorkingDirectory, \".+\", needs to be a directory.")); - final File tmpDir = File.createTempFile(ImageOptimizationServiceTest.class.getName(), ""); - tmpDir.delete(); - tmpDir.mkdir(); + final File tmpDir = Files.createTempDirectory(ImageOptimizationServiceTest.class.getName()).toFile(); tmpDir.deleteOnExit(); assertThat(new ImageOptimizationService<>(tmpDir, new File(DEFAULT_BINARY_APP_LOCATION)), notNullValue()); } @@ -150,9 +147,7 @@ public void testImageOptimizationService2() throws IOException { actualException = assertThrows(IllegalArgumentException.class, () -> new ImageOptimizationService<>(file, new File(DEFAULT_BINARY_APP_LOCATION), 1)); assertThat(actualException.getMessage(), matchesRegex("The passed in tmpWorkingDirectory, \".+\", needs to be a directory.")); - File tmpDir = File.createTempFile(ImageOptimizationServiceTest.class.getName(), ""); - tmpDir.delete(); - tmpDir.mkdir(); + File tmpDir = Files.createTempDirectory(ImageOptimizationServiceTest.class.getName()).toFile(); tmpDir.deleteOnExit(); assertThat(new ImageOptimizationService<>(tmpDir, new File(DEFAULT_BINARY_APP_LOCATION), 1), notNullValue()); @@ -166,9 +161,7 @@ public void testImageOptimizationService2() throws IOException { file2.deleteOnExit(); actualException = assertThrows(IllegalArgumentException.class, () -> new ImageOptimizationService<>(file2, new File(DEFAULT_BINARY_APP_LOCATION), 0)); - tmpDir = File.createTempFile(ImageOptimizationServiceTest.class.getName(), ""); - tmpDir.delete(); - tmpDir.mkdir(); + tmpDir = Files.createTempDirectory(ImageOptimizationServiceTest.class.getName()).toFile(); tmpDir.deleteOnExit(); assertThat(new ImageOptimizationService<>(tmpDir, new File(DEFAULT_BINARY_APP_LOCATION), 0), notNullValue()); } @@ -222,9 +215,7 @@ private static final void validateFileOptimization(final OptimizationResult