From 34ccd268c4f3a0c69e7825d7db8cb56c1a1d944b Mon Sep 17 00:00:00 2001 From: mshanemc Date: Fri, 26 Jul 2024 09:49:07 -0500 Subject: [PATCH 1/2] feat: no ctc for prerelease --- .github/workflows/npmPublish.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/npmPublish.yml b/.github/workflows/npmPublish.yml index a0419c3..ee75c2e 100644 --- a/.github/workflows/npmPublish.yml +++ b/.github/workflows/npmPublish.yml @@ -83,7 +83,7 @@ jobs: ctc-open: needs: [check-publish] - if: inputs.ctc && needs.check-publish.outputs.published == 'false' + if: inputs.ctc && needs.check-publish.outputs.published == 'false' && inputs.tag == 'latest' uses: salesforcecli/github-workflows/.github/workflows/ctcOpen.yml@main secrets: inherit @@ -118,7 +118,7 @@ jobs: ctcCloseSuccess: needs: [ctc-open, npm-publish] - if: needs.ctc-open.result == 'success' && needs.npm-publish.result == 'success' && needs.ctc-open.outputs.changeCaseId + if: needs.ctc-open.result == 'success' && needs.npm-publish.result == 'success' && needs.ctc-open.outputs.changeCaseId && inputs.tag == 'latest' uses: salesforcecli/github-workflows/.github/workflows/ctcClose.yml@main secrets: inherit with: @@ -126,7 +126,7 @@ jobs: ctcCloseFail: needs: [ctc-open, npm-publish] - if: always() && inputs.ctc && needs.ctc-open.outputs.changeCaseId && (needs.ctc-open.result != 'success' || needs.npm-publish.result != 'success') + if: always() && inputs.ctc && needs.ctc-open.outputs.changeCaseId && (needs.ctc-open.result != 'success' || needs.npm-publish.result != 'success') && inputs.tag == 'latest' uses: salesforcecli/github-workflows/.github/workflows/ctcClose.yml@main secrets: inherit with: From 0d6a7d5d88dc0a596e612dbd0503e94ecd21760c Mon Sep 17 00:00:00 2001 From: Shane McLaughlin Date: Mon, 29 Jul 2024 11:20:08 -0500 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Willhoit --- .github/workflows/npmPublish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/npmPublish.yml b/.github/workflows/npmPublish.yml index ee75c2e..617d389 100644 --- a/.github/workflows/npmPublish.yml +++ b/.github/workflows/npmPublish.yml @@ -118,7 +118,7 @@ jobs: ctcCloseSuccess: needs: [ctc-open, npm-publish] - if: needs.ctc-open.result == 'success' && needs.npm-publish.result == 'success' && needs.ctc-open.outputs.changeCaseId && inputs.tag == 'latest' + if: needs.ctc-open.result == 'success' && needs.npm-publish.result == 'success' && needs.ctc-open.outputs.changeCaseId uses: salesforcecli/github-workflows/.github/workflows/ctcClose.yml@main secrets: inherit with: @@ -126,7 +126,7 @@ jobs: ctcCloseFail: needs: [ctc-open, npm-publish] - if: always() && inputs.ctc && needs.ctc-open.outputs.changeCaseId && (needs.ctc-open.result != 'success' || needs.npm-publish.result != 'success') && inputs.tag == 'latest' + if: always() && inputs.ctc && needs.ctc-open.outputs.changeCaseId && (needs.ctc-open.result != 'success' || needs.npm-publish.result != 'success') uses: salesforcecli/github-workflows/.github/workflows/ctcClose.yml@main secrets: inherit with: