Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support webpack 5 #32

Open
ruscon opened this issue Aug 30, 2020 · 0 comments
Open

feat: support webpack 5 #32

ruscon opened this issue Aug 30, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ruscon
Copy link

ruscon commented Aug 30, 2020

As I see, you have a lot of real dependencies here
https://github.com/saltyshiomix/react-ssr/blob/master/packages/core/package.json

Apparently, this is the cause of problems for some webpack plugins, because multiple versions of webpack are installed at the same time (webpack@5 by project and webpack@4 by your library)

I think many dependencies can (and should) be moved to peerDependencies

@saltyshiomix saltyshiomix added the good first issue Good for newcomers label Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants