-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of CRAM 3.1 codecs. #1714
base: master
Are you sure you want to change the base?
Conversation
008cebd
to
b92597b
Compare
b92597b
to
bfb60ea
Compare
…safe, precompile the name Tok regex, eliminate unnecessary code.
Hello. Thank you very much for this PR! I learned this fix is critical for an IGV upgrade to support CRAM v3.1, which is very important to our projects. I am wondering if there’s an estimated timeline for merging. Much appreciated! |
…ns, fix the read name separator.
@jerryliu2005 This branch is nearly done, but there are a few TODOs left, plus I want to do some more large-scale round trip testing. Those should get done over the next couple of weeks. However, this branch doesn't actually turn on CRAM 3.1 support - I have a separate, smaller branch for that which I'm using for testing. Once those are merged, we'll need to do an htsjdk release, and then IGV can upgrade. I'd hope/expect that all to happen in the Jan/Feb timeframe. |
Hi @cmnbroad, thanks very much for the info! I will let the team know about the rough timeframe to be ready :) |
This is a squashed and rebased branch containing all of the changes from Yash's CRAM 3.1 codec branches. Draft until I get all of the issues resolved. Replacement for #1618, 1644, 1663 and 1704.