Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict hotkeys to files using tasks syntax #12

Open
samuelmaddock opened this issue Sep 17, 2016 · 6 comments
Open

Restrict hotkeys to files using tasks syntax #12

samuelmaddock opened this issue Sep 17, 2016 · 6 comments

Comments

@samuelmaddock
Copy link

After installing this plugin, I was unable to use the ctrl+enter hotkey to insert a new line in any editor view. I think this plugin's hotkeys should be limited to files using the tasks syntax if possible.

This would also fix the issue in #10

@dtasev
Copy link

dtasev commented Oct 21, 2016

@samuelmaddock Seems to me this is a full duplicate of #10, but in any case, I can't replicate the issue on VSCode 1.6.1, the command(insertLineAfter) is working properly after rebinding it in the keybinding.json file.
vscode-todotasks version:

Version
0.4.0
Last updated
9/30/2016, 1:33:11 PM

This is both with and without having the alt+i command rebound to task.new.

@kidoman
Copy link

kidoman commented Nov 26, 2016

Had the same issue.

This:

                        {
                                "command": "task.new",
                                "key": "Ctrl+Enter",
                                "mac": "Cmd+Enter",
                                "when": "editorTextFocus"
                        }

essentially the base "Cmd+Enter" shortcut on VSCode as the "when" condition is exactly the same. Please add the language filter to the extensions shortcut.

rbenson added a commit to rbenson/vscode-todotasks that referenced this issue Mar 12, 2017
@rbenson
Copy link

rbenson commented Jul 6, 2017

When I did #21, it fixed the keybindings to restrict them to only work if the language was set to todo (Tasks in the status bar). I noticed this fix wasn't working anymore - I applied it locally since 21 isn't approved. Removing the language restriction allowed the bindings to work again, and not interfering with other languages. Can anybody confirm? @sandy081 can you comment if something changed on the backend?

@kidoman
Copy link

kidoman commented Jul 6, 2017

Yep, it broke for me too... i had to disable this extension for now.

@rbenson
Copy link

rbenson commented Jul 6, 2017

So after I posted, something changed because it broke again! I restarted VSC two times before posing

@sveggiani
Copy link

Broken for me too. VSC 1.17.1 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants