Skip to content

Commit

Permalink
Revert sisl dependency to v10. (eBay#68)
Browse files Browse the repository at this point in the history
  • Loading branch information
szmyd authored Dec 15, 2023
1 parent 02fa759 commit c99fd9b
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 13 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/build_commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ on:
type: string

jobs:
SislDeps:
uses: eBay/sisl/.github/workflows/build_dependencies.yml@master
Sisl10Deps:
uses: eBay/sisl/.github/workflows/build_dependencies.yml@stable/v10.x
with:
branch: master
branch: stable/v10.x
platform: ${{ inputs.platform }}
build-type: ${{ inputs.build-type }}
malloc-impl: ${{ inputs.malloc-impl }}
Expand All @@ -32,7 +32,7 @@ jobs:
if: ${{ github.event_name != 'pull_request' }}

IOMgrDeps:
needs: SislDeps
needs: Sisl10Deps
uses: ./.github/workflows/build_dependencies.yml
with:
branch: ${{ github.ref }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/build_dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,15 +109,15 @@ jobs:
with:
repository: eBay/sisl
path: import/sisl
ref: master
ref: stable/v10.x
if: ${{ inputs.testing == 'True' || steps.restore-cache.outputs.cache-hit != 'true' }}

- name: Load Sisl Cache
uses: eBay/sisl/.github/actions/load_conan@stable/v8.x
with:
testing: 'False'
path: import/sisl
key_prefix: SislDeps-${{ inputs.platform }}-${{ inputs.build-type }}-${{ inputs.malloc-impl }}-${{ inputs.prerelease }}
key_prefix: Sisl10Deps-${{ inputs.platform }}-${{ inputs.build-type }}-${{ inputs.malloc-impl }}-${{ inputs.prerelease }}
fail_on_cache_miss: true
if: ${{ inputs.testing == 'True' || steps.restore-cache.outputs.cache-hit != 'true' }}

Expand All @@ -130,7 +130,7 @@ jobs:
- name: Prepare Recipes
run: |
./prepare.sh
conan export import/sisl oss/master
conan export import/sisl
cached_pkgs=$(ls -1d ~/.conan/data/*/*/*/*/package | sed 's,.*data/,,' | cut -d'/' -f1,2 | paste -sd',' - -)
echo "::info:: Pre-cached: ${cached_pkgs}"
if: ${{ inputs.testing == 'True' || steps.restore-cache.outputs.cache-hit != 'true' }}
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
with:
testing: 'False'
path: import/sisl
key_prefix: SislDeps-${{ inputs.platform }}-${{ inputs.build-type }}-${{ inputs.malloc-impl }}-${{ inputs.prerelease }}
key_prefix: Sisl10Deps-${{ inputs.platform }}-${{ inputs.build-type }}-${{ inputs.malloc-impl }}-${{ inputs.prerelease }}
fail_on_cache_miss: true
if: ${{ inputs.testing == 'True' && github.event_name != 'pull_request' && steps.restore-cache.outputs.cache-hit != 'true' }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/merge_build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: IOManager Build
name: IOManager Merge Build

on:
workflow_dispatch:
Expand Down
2 changes: 1 addition & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def build_requirements(self):
self.build_requires("cpr/1.10.4")

def requirements(self):
self.requires("sisl/[~=11, include_prerelease=True]@oss/master")
self.requires("sisl/[>=10.3]")

if self.options.grpc_support:
self.requires("grpc/1.50.1")
Expand Down
3 changes: 2 additions & 1 deletion src/lib/iomgr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ SISL_OPTION_GROUP(iomgr,
(hdd_streams, "", "hdd_streams", "Number of streams for hdd - overridden value",
::cxxopts::value< uint32_t >(), "count"))

SISL_LOGGING_DEF(iomgr)
// SISL v11 change
//SISL_LOGGING_DEF(iomgr)

namespace iomgr {

Expand Down
3 changes: 2 additions & 1 deletion src/lib/spdk/iomgr_impl_spdk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ extern "C" {
#include <rte_malloc.h>
}

SISL_LOGGING_DEF(spdk)
// SISL v11 change
//SISL_LOGGING_DEF(spdk)

namespace iomgr {
bool IOManagerSpdkImpl::g_spdk_env_prepared{false};
Expand Down
3 changes: 2 additions & 1 deletion src/lib/watchdog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
#include "watchdog.hpp"
#include "iomgr_config.hpp"

SISL_LOGGING_DEF(io_wd)
// SISL v11 change
//SISL_LOGGING_DEF(io_wd)

namespace iomgr {
IOWatchDog::IOWatchDog() {
Expand Down

0 comments on commit c99fd9b

Please sign in to comment.