Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Refresh #8

Open
myounees opened this issue Oct 20, 2020 · 2 comments
Open

Force Refresh #8

myounees opened this issue Oct 20, 2020 · 2 comments

Comments

@myounees
Copy link

Hi, nice implementation easy to use package. yet it needs some enhancements:

  1. when using in a child component, it doesn't render (consider a child of app component and there you show the image-fullscreen-viewer).
  2. when image is url, the spinner continue to spin even if the image is loaded, you need to close the fullscreen-viewer and reopen it again.
@ukaya0
Copy link

ukaya0 commented Apr 10, 2021

I have the same issue when I use changeDetection: ChangeDetectionStrategy.OnPush

@jjbenitez026
Copy link

Hi, nice implementation easy to use package. yet it needs some enhancements:

  1. when using in a child component, it doesn't render (consider a child of app component and there you show the image-fullscreen-viewer).
  2. when image is url, the spinner continue to spin even if the image is loaded, you need to close the fullscreen-viewer and reopen it again.

Any workaround to the point 2.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants