Skip to content

Make this lib Strict Mode compliant #198

@gustavopch

Description

@gustavopch

Getting the following error when using this lib in Strict Mode:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputElement which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node

This line seems to be the cause: https://github.com/sanniassin/react-input-mask/blob/master/src/index.js#L270

This should be fixed to avoid issues with Concurrent Mode (which will soon be released):

In Concurrent Mode, the lifecycle methods previously marked as “unsafe” actually are unsafe, and lead to bugs even more than in today’s React. We don’t recommend trying Concurrent Mode until your app is Strict Mode-compatible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions