Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the need to install mockgen #82

Open
sanposhiho opened this issue Dec 28, 2021 · 1 comment
Open

Eliminate the need to install mockgen #82

sanposhiho opened this issue Dec 28, 2021 · 1 comment

Comments

@sanposhiho
Copy link
Owner

sanposhiho commented Dec 28, 2021

Let's eliminate the need to install mockgen.


We currently require users to install it. But, unexpected behaviors may occur due to differences in mockgen behavior depending on which mockgen the user has installed.
Ideally, we should generate mocks without using user-installed mockgen and we can achieve that if we can import mockgen.


But currently, almost all logic of mockgen cannot be imported, because it is placed in main package.
So, I propose to fork golang/mock, add changes to make it importable, and use the fork to import mockgen.

And, I raised the issue for golang/mock.
golang/mock#609

@sanposhiho
Copy link
Owner Author

sanposhiho commented Dec 28, 2021

We don't need to increment the major version for this change.
The mode of using user's mockgen is necessary (because some users may want to use a specific version of mockgen.) and will not be removed, so it is backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant