New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in README #4

Open

chenghancc opened this issue Mar 31, 2022 · 0 comments

chenghancc commented Mar 31, 2022

Hello, I found an error in Usage.

That's what you write in usage:

from pydpp.dpp import DPP
import numpy as np
X = np.random.random((10,10))
dpp = DPP(X)
dpp.compute_kernel(kernel_type = 'rbf', sigma= 0.4) # use 'cos-sim' for cosine similarity
samples = dpp.samples() # samples := [1,7,2,5]
ksamlpes = dpp.sample_k(3) # ksamples := [5,8,0]

However,

samples = dpp.samlpe()
should be used when sampling, you wrote an extra s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment