Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whisper-writer Popup Stuck on "Recording" After Transcription #49

Closed
murtaza-nasir opened this issue Jun 3, 2024 · 4 comments
Closed

Comments

@murtaza-nasir
Copy link

Thank you for the fantastic whisper-writer app! I got CUDA working thanks to the helpful reply in #33

I have the app set to record only when I press the default key combo. After transcription, the popup switches back to "Recording" even though I'm not recording. It stays there until closed manually.

Has anyone else faced this issue? Any help would be appreciated.

@savbell
Copy link
Owner

savbell commented Jun 3, 2024

Hi, thank you for your issue! I'm glad you were able to get CUDA working.

When you say you have the app set to record only when you press the default key combo, which recording mode exactly do you have set?

In the latest update, I added a new recording mode called continuous which is the new default. It's expected behaviour to start recording again after transcribing until the activation key combo is pressed again. The other modes — voice_activity_detection, press_to_toggle, and hold_to_record — should not do this. Are you running into this problem with one of them?

Thanks,
Sav

@murtaza-nasir
Copy link
Author

I am using hold_to_record.

I turned on "hide status window" to get rid of the recording/transcribing notification, but I noticed another issue in this case. Now I see that the recording keeps on going after transcribing, even with hold_to_record. The terminal window shows "Recording...", the windows notification tray has a recording indication ("Python is using your microphone") but the app seems to be recording into the void and not transcribing anything. Now when I press the recording key combo, it records something but the output is gibberish like "You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. You are a very good listener. "

@savbell
Copy link
Owner

savbell commented Jun 3, 2024

Thanks for providing more detail! I realized I introduced a bug when I added the logic for the continuous recording mode, but I've just pushed a fix that should fix the issue! Please try it out and let me know if it works for you.

As for your other issue, I've addressed that a bit in #46. Hopefully fixing the continuously recording issue will help make sure only what you want recorded will be recorded, but unfortunately sometimes the models hallucinate even when given decent data. If this is continuing to be a big problem after the bugfix, please experiment a bit with the model you are using to see if that helps.

Cheers,
Sav

@murtaza-nasir
Copy link
Author

Thank you so much for the quick fixes! The lingering status notification bug has been fixed! Haven't tried to replicate the other issue, since it was only happening when I was enabling the hide status window option, which I am not doing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants