feat(sbb-tag, sbb-tag-group): implement native form support #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioCastigliano
requested review from
kyubisation and
jeripeierSBB
as code owners
github-actions
bot
added
the
pr: peer review required
DavideMininni-Fincons
requested changes
Feb 4, 2025
| @@ -42,7 +42,7 @@ $active: ':active, [data-active]'; | |||
| } | |||
|
|
|||
| // Active state | |||
| :host([checked]) { | |||
| :host([aria-pressed='true']) { | |||
There was a problem hiding this comment.
Are there issues to have reflect=true in the checked property?
| ); | ||
| }); | ||
|
|
||
| it('updates form in exlusive mode', async () => { |
There was a problem hiding this comment.
Suggested change
| it('updates form in exlusive mode', async () => { | |
| it('updates form in exclusive mode', async () => { |
| @@ -105,6 +105,7 @@ that communicates the collective meaning of all `sbb-tag`s. | |||
|
|
|||
| | Name | Attribute | Privacy | Type | Default | Description | | |||
| | ------------------------ | -------------------------- | ------- | -------------------------------------- | ------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | `disabled` | `disabled` | public | `boolean` | `false` | Whether the component is disabled. | | |||
There was a problem hiding this comment.
I will add a note in style or state saying that the component can be disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preflight Checklist
Issue
This PR Closes #3157
Pull request checklist
Please check if your PR fulfills the following requirements:
See Review Guidelines for more information what is checked during review process.
Changes
Changes in this pull request:
Browsers
I tested the build on the following browsers:
Screen readers
I tested the build on the following browsers:
Pull request type
Please check the type of change your PR introduces:
Does this introduce a breaking change?
Other information