Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Environment #15

Open
sbuberl opened this issue Aug 26, 2017 · 1 comment
Open

Refactor Environment #15

sbuberl opened this issue Aug 26, 2017 · 1 comment
Assignees
Milestone

Comments

@sbuberl
Copy link
Owner

sbuberl commented Aug 26, 2017

Environment is a mess. Last stable release this was all one php file (with less features).

In preparation for #10, first thing I want to do is separate the parsing and execution logic. The execution logic should go in classes in Statement classes. The parsing can stay in Environment for now. Right now, only all the Create queries and Insert have Statement classes.

While adding these Statement classes is a good time to add testing. Rather than adding unit tests for the Statement, add testing for the SQL command. See tests/SQL for example.

Once everything is in a Statement would to like pull out all the parsing logic in Environment into a new Parser class but not required.

@sbuberl sbuberl added this to the 1.4 milestone Aug 28, 2017
@sbuberl sbuberl self-assigned this Sep 19, 2018
@sbuberl
Copy link
Owner Author

sbuberl commented Feb 17, 2019

As right now, all the queries have been refactored into Statements and have tests. I just need to move the parser logic into a new class (or multiple?) and this will be done.

sbuberl added a commit that referenced this issue Mar 5, 2019
sbuberl added a commit that referenced this issue May 29, 2019
Parse ALTER, CREATE, transaction ones, and UNLOCK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant