Best effort failure excluded

Author: som-snytt

compiler/test/dotc/neg-best-effort-unpickling.excludelist

@@ -24,3 +24,6 @@ context-function-syntax.scala
 
 # Failure to disambiguate overloaded reference
 i23402b.scala
+
+# owner of anon, where package object has funky name
+i20511-1.scala

compiler/test/dotty/tools/dotc/BestEffortOptionsTests.scala

@@ -2,44 +2,42 @@ package dotty
 package tools
 package dotc
 
-import scala.concurrent.duration._
-import dotty.tools.vulpix._
-import org.junit.{ Test, AfterClass }
+import dotty.tools.vulpix.*
 import reporting.TestReporter
-import java.io.{File => JFile}
 
+import scala.concurrent.duration.*
 import scala.language.unsafeNulls
 
+import java.io.{File => JFile}
+import org.junit.{AfterClass, Test}
+
 class BestEffortOptionsTests {
-  import ParallelTesting._
-  import vulpix.TestConfiguration._
-  import BestEffortOptionsTests._
-  import CompilationTest.aggregateTests
+  import ParallelTesting.*
+  import vulpix.TestConfiguration.*
+  import BestEffortOptionsTests.*
 
   // Since TASTy and beTASTy files are read in a lazy manner (only when referenced by the source .scala file)
   // we test by using the "-from-tasty" option. This guarantees that the tasty files will be read
   // (and that the Best Effort TASTy reader will be tested), but we unfortunately skip the useful
   // interactions a tree derived from beTASTy could have with other frontend phases.
-  @Test def negTestFromBestEffortTasty: Unit = {
+  @Test def negTestFromBestEffortTasty: Unit =
     // Can be reproduced with
     // > sbt
-    // > scalac --Ybest-effort -Xsemanticdb <source>
-    // > scalac --from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
+    // > scalac -Ybest-effort -Xsemanticdb <source>
+    // > scalac -from-tasty -Ywith-best-effort-tasty META_INF/best-effort/<betasty>
 
-    implicit val testGroup: TestGroup = TestGroup("negTestFromBestEffortTasty")
+    given TestGroup = TestGroup("negTestFromBestEffortTasty")
     compileBestEffortTastyInDir(s"tests${JFile.separator}neg", bestEffortBaselineOptions,
       picklingFilter = FileFilter.exclude(TestSources.negBestEffortPicklingExcludelisted),
       unpicklingFilter = FileFilter.exclude(TestSources.negBestEffortUnpicklingExcludelisted)
     ).checkNoCrash()
-  }
 
   // Tests an actual use case of this compilation mode, where symbol definitions of the downstream
   // projects depend on the best effort tasty files generated with the Best Effort dir option
-  @Test def bestEffortIntergrationTest: Unit = {
-    implicit val testGroup: TestGroup = TestGroup("bestEffortIntegrationTests")
+  @Test def bestEffortIntegrationTest: Unit =
+    given TestGroup = TestGroup("bestEffortIntegrationTests")
     compileBestEffortIntegration(s"tests${JFile.separator}best-effort", bestEffortBaselineOptions)
       .noCrashWithCompilingDependencies()
-  }
 }
 
 object BestEffortOptionsTests extends ParallelTesting {