Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add pre-commit/pygrep-hooks to pre-commit hooks #2382

Merged
merged 2 commits into from
Nov 17, 2023
Merged

chore: Add pre-commit/pygrep-hooks to pre-commit hooks #2382

merged 2 commits into from
Nov 17, 2023

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 17, 2023 •
edited
Loading

Description

Impliment repo-review PC170: Uses PyGrep hooks (only needed if RST present).

✅ PC170 Uses PyGrep hooks (only needed if RST present)

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Impliment repo-review PC170: Uses PyGrep hooks (only needed if RST present).
   - c.f. https://learn.scientific-python.org/development/guides/style/#PC170

@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Nov 17, 2023
@matthewfeickert matthewfeickert self-assigned this Nov 17, 2023
@matthewfeickert matthewfeickert added pre-commit Related to pre-commit hooks backport Backport PRs from main to release branch need-to-backport tmp label until can be backported to patch release branch and removed backport Backport PRs from main to release branch labels Nov 17, 2023
@matthewfeickert matthewfeickert merged commit 156bd11 into main Nov 17, 2023
20 checks passed
@matthewfeickert matthewfeickert deleted the chore/add-pygrep-hooks branch November 17, 2023 20:30
@matthewfeickert matthewfeickert mentioned this pull request Jan 5, 2024
Merged
4 tasks
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Jan 5, 2024
matthewfeickert added a commit that referenced this pull request Jan 5, 2024
@matthewfeickert
chore(backport): Update pre-commit hooks (#2424)
c45f8c4 
* Backport:
   - PR #2378
   - PR #2380
   - PR #2381
   - PR #2382
   - PR #2383
   - PR #2386
   - PR #2412
   - PR #2414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewfeickert matthewfeickert

Labels
chore Other changes that don't modify src or test files pre-commit Related to pre-commit hooks
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert