Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove codemeta from repository #2490

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 29, 2024

Description

  • Remove all files, tests, and documentation related to codemeta, codemeta.json, and codemetapy.
  • codemeta is not realistically used for anything useful and codemetapy is not maintained, so there is no strong reason to keep using codemeta or to have a codemeta.json.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Remove all files, tests, and documentation related to codemeta,
  codemeta.json, and codemetapy.
* codemeta is not realistically used for anything useful and codemetapy
  is not maintained, so there is no strong reason to keep using codemeta
  or to have a codemeta.json.

* Remove all files, tests, and documentation related to codemeta,
  codemeta.json, and codemeta.py.
* codemeta is not realistically used for anything useful and codemetapy
  is not maintained, so there is no strong reason to keep using codemeta
  or to have a codemeta.json.
@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files need-to-backport tmp label until can be backported to patch release branch labels May 29, 2024
@matthewfeickert matthewfeickert requested a review from kratsg May 29, 2024 17:17
@matthewfeickert matthewfeickert self-assigned this May 29, 2024
@matthewfeickert
Copy link
Member Author

On this branch

git grep "codemeta"

returns nothing now.

@matthewfeickert matthewfeickert added the docs Documentation related label May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (1af5ed4) to head (1649bab).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2490   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          69       69           
  Lines        4543     4543           
  Branches      804      804           
=======================================
  Hits         4462     4462           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 97.79% <ø> (ø)
doctest 98.08% <ø> (ø)
unittests-3.10 96.23% <ø> (ø)
unittests-3.11 96.23% <ø> (ø)
unittests-3.12 96.23% <ø> (ø)
unittests-3.8 96.25% <ø> (ø)
unittests-3.9 96.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member Author

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit ba896a6 into main May 30, 2024
25 of 31 checks passed
@matthewfeickert matthewfeickert deleted the chore/remove-codemeta branch May 30, 2024 19:40
@matthewfeickert
Copy link
Member Author

@meeseeksdev backport to release/v0.7.x

Copy link

lumberbot-app bot commented May 30, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout release/v0.7.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 ba896a6e1195470030a3b7b2480d5d68202fbc0d
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #2490: chore: Remove codemeta from repository'
  1. Push to a named branch:
git push YOURFORK release/v0.7.x:auto-backport-of-pr-2490-on-release/v0.7.x
  1. Create a PR against branch release/v0.7.x, I would have named this PR:

"Backport PR #2490 on branch release/v0.7.x (chore: Remove codemeta from repository)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@matthewfeickert matthewfeickert removed need-to-backport tmp label until can be backported to patch release branch Still Needs Manual Backport labels May 30, 2024
matthewfeickert added a commit that referenced this pull request May 30, 2024
* Backport PR #2490
* Remove all files, tests, and documentation related to codemeta,
  codemeta.json, and codemetapy.
* codemeta is not realistically used for anything useful and codemetapy
  is not maintained, so there is no strong reason to keep using codemeta
  or to have a codemeta.json.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files docs Documentation related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant