test: Lower tolerance for iminuit v2.26.0+ on Apple silicon #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Lower the tolerance for the tests/test_optim.py test_optim_uncerts test to reach agreement for iminuit v2.26.0 on Apple silicon.
matthewfeickert
added
tests
|
I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2514 +/- ##
==========================================
+ Coverage 98.08% 98.21% +0.13%
==========================================
Files 69 69
Lines 4543 4543
Branches 696 804 +108
==========================================
+ Hits 4456 4462 +6
+ Misses 51 48 -3
+ Partials 36 33 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matthewfeickert
removed
the
need-to-backport
|
@meeseeksdev backport to release/v0.7.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pyhf
that referenced
this pull request
Jun 7, 2024
…0+ on Apple silicon
matthewfeickert
added a commit
that referenced
this pull request
Jun 7, 2024
…#2515) * Backport PR #2514 * Lower the tolerance for the tests/test_optim.py test_optim_uncerts test to reach agreement for iminuit v2.26.0+ on Apple silicon. Co-authored-by: Matthew Feickert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lower the tolerance for the
tests/test_optim.pytest_optim_uncertstest to reach agreement foriminuitv2.26.0+on Apple silicon.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: