Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teacher Registration - Flag icons in phone number field not necessarily correct #689

Open
jwzimmer-zz opened this issue Jul 7, 2016 · 3 comments

Comments

@jwzimmer-zz
Copy link
Contributor

It looks like the source for the flag icons may be out of date - the Tuvalu Islands flag icon seems to be of their previous flag, which was superceded by the current flag in 1997 (so, a pretty long time ago!).

I did not check each flag icon to see if it was correct : ) but finding at least one incorrect flag seems to me to indicate that other flags may be incorrect as well.

screen shot 2016-07-07 at 10 13 22 am

screen shot 2016-07-07 at 10 13 44 am

@jwzimmer-zz
Copy link
Contributor Author

The Wallis and Futuna flag also seems to be their unofficial flag rather than their official flag, which seems to be the flag of France... I'm not sure if it could be taking a political stance to choose one or the other of those flag options...:
screen shot 2016-07-07 at 10 29 36 am
screen shot 2016-07-07 at 10 29 25 am

@jwzimmer-zz
Copy link
Contributor Author

As @mewtaylor suggested, opened an issue for this in the repo for the phone number tool as well: mukeshsoni/react-telephone-input#73

@jwzimmer-zz
Copy link
Contributor Author

The author of the phone number tool said:

You can use custom image for flags by using flagsImagePath prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants