Enable eslint (videojs#96)

jshint was misconfigured or just terrible at detecting issues in this project. Swap it with eslint instead and setup a configuration based on the video.js standard. Fix a number of easy linting issues and then tweak the configuration to warn for most of the others. This is definitely worth another pass but puts us in a much better position than we were with basically no linting at all.

Author: dmlap

.eslintrc.json

@@ -43,7 +43,6 @@
     "func-style": [2, "expression"],
     "guard-for-in": 0,
     "handle-callback-err": [2, "^(err|error|anySpecificError)$"],
-    "indent": [2, 2],
     "key-spacing": [2, {"beforeColon": false, "afterColon": true}],
     "keyword-spacing": 2,
     "max-depth": 0,
@@ -97,9 +96,9 @@
     "no-loop-func": 1,
     "no-mixed-requires": [0, false],
     "no-mixed-spaces-and-tabs": [2, false],
-    "no-multi-spaces": 2,
+    "no-multi-spaces": 1,
     "no-multi-str": 2,
-    "no-multiple-empty-lines": [2, {"max": 1}],
+    "no-multiple-empty-lines": [2, {"max": 2}],
     "no-native-reassign": 2,
     "no-negated-in-lhs": 2,
     "no-nested-ternary": 1,
@@ -124,7 +123,7 @@
     "no-script-url": 2,
     "no-self-compare": 1,
     "no-sequences": 2,
-    "no-shadow": 2,
+    "no-shadow": 1,
     "no-shadow-restricted-names": 2,
     "no-spaced-func": 2,
     "no-sparse-arrays": 2,
@@ -146,7 +145,7 @@
     "operator-assignment": [0, "always"],
     "operator-linebreak": [2, "after"],
     "padded-blocks": 0,
-    "quote-props": [2, "consistent-as-needed"],
+    "quote-props": [2, "as-needed"],
     "quotes": [2, "single", "avoid-escape"],
     "radix": 2,
     "semi": [2, "always"],
@@ -163,7 +162,7 @@
     "use-isnan": 2,
     "valid-jsdoc": 0,
     "valid-typeof": 2,
-    "vars-on-top": 2,
+    "vars-on-top": 1,
     "wrap-iife": [2, "outside"],
     "wrap-regex": 2,
     "yoda": [2, "never"]

lib/aac/index.js

@@ -21,12 +21,11 @@ var AacStream;
 AacStream = function() {
   var
     everything = new Uint8Array(),
-    receivedTimeStamp = false,
     timeStamp = 0;
 
   AacStream.prototype.init.call(this);
 
-  this.setTimestamp = function (timestamp) {
+  this.setTimestamp = function(timestamp) {
     timeStamp = timestamp;
   };
 
@@ -121,7 +120,7 @@ AacStream = function() {
           type: 'audio',
           data: everything.subarray(byteIndex, byteIndex + frameSize),
           pts: timeStamp,
-          dts: timeStamp,
+          dts: timeStamp
         };
         this.trigger('data', packet);
         byteIndex += frameSize;
@@ -141,6 +140,4 @@ AacStream = function() {
 
 AacStream.prototype = new Stream();
 
-
-
 module.exports = AacStream;

lib/codecs/adts.js

@@ -30,12 +30,10 @@ var
  * @see http://wiki.multimedia.cx/?title=Understanding_AAC
  */
 AdtsStream = function() {
-  var self, buffer;
+  var buffer;
 
   AdtsStream.prototype.init.call(this);
 
-  self = this;
-
   this.push = function(packet) {
     var
       i = 0,
@@ -44,7 +42,6 @@ AdtsStream = function() {
       protectionSkipBytes,
       frameEnd,
       oldBuffer,
-      numFrames,
       sampleCount,
       adtsFrameDuration;
 

lib/codecs/h264.js

@@ -4,6 +4,7 @@ var Stream = require('../utils/stream.js');
 var ExpGolomb = require('../utils/exp-golomb.js');
 
 var H264Stream, NalByteStream;
+var PROFILES_WITH_OPTIONAL_SPS_DATA;
 
 /**
  * Accepts a NAL unit byte stream and unpacks the embedded NAL units.
@@ -61,7 +62,7 @@ NalByteStream = function() {
         }
 
         // deliver the NAL unit if it isn't empty
-        if (syncPoint + 3 !==  i - 2) {
+        if (syncPoint + 3 !== i - 2) {
           this.trigger('data', buffer.subarray(syncPoint + 3, i - 2));
         }
 
@@ -111,6 +112,24 @@ NalByteStream = function() {
 };
 NalByteStream.prototype = new Stream();
 
+// values of profile_idc that indicate additional fields are included in the SPS
+// see Recommendation ITU-T H.264 (4/2013),
+// 7.3.2.1.1 Sequence parameter set data syntax
+PROFILES_WITH_OPTIONAL_SPS_DATA = {
+  100: true,
+  110: true,
+  122: true,
+  244: true,
+  44: true,
+  83: true,
+  86: true,
+  118: true,
+  128: true,
+  138: true,
+  139: true,
+  134: true
+};
+
 /**
  * Accepts input from a ElementaryStream and produces H.264 NAL unit data
  * events.
@@ -291,18 +310,7 @@ H264Stream = function() {
     expGolombDecoder.skipUnsignedExpGolomb(); // seq_parameter_set_id
 
     // some profiles have more optional data we don't need
-    if (profileIdc === 100 ||
-        profileIdc === 110 ||
-        profileIdc === 122 ||
-        profileIdc === 244 ||
-        profileIdc ===  44 ||
-        profileIdc ===  83 ||
-        profileIdc ===  86 ||
-        profileIdc === 118 ||
-        profileIdc === 128 ||
-        profileIdc === 138 ||
-        profileIdc === 139 ||
-        profileIdc === 134) {
+    if (PROFILES_WITH_OPTIONAL_SPS_DATA[profileIdc]) {
       chromaFormatIdc = expGolombDecoder.readUnsignedExpGolomb();
       if (chromaFormatIdc === 3) {
         expGolombDecoder.skipBits(1); // separate_colour_plane_flag
@@ -328,13 +336,13 @@ H264Stream = function() {
     picOrderCntType = expGolombDecoder.readUnsignedExpGolomb();
 
     if (picOrderCntType === 0) {
-      expGolombDecoder.readUnsignedExpGolomb(); //log2_max_pic_order_cnt_lsb_minus4
+      expGolombDecoder.readUnsignedExpGolomb(); // log2_max_pic_order_cnt_lsb_minus4
     } else if (picOrderCntType === 1) {
       expGolombDecoder.skipBits(1); // delta_pic_order_always_zero_flag
       expGolombDecoder.skipExpGolomb(); // offset_for_non_ref_pic
       expGolombDecoder.skipExpGolomb(); // offset_for_top_to_bottom_field
       numRefFramesInPicOrderCntCycle = expGolombDecoder.readUnsignedExpGolomb();
-      for(i = 0; i < numRefFramesInPicOrderCntCycle; i++) {
+      for (i = 0; i < numRefFramesInPicOrderCntCycle; i++) {
         expGolombDecoder.skipExpGolomb(); // offset_for_ref_frame[ i ]
       }
     }
@@ -363,22 +371,22 @@ H264Stream = function() {
         // aspect_ratio_info_present_flag
         aspectRatioIdc = expGolombDecoder.readUnsignedByte();
         switch (aspectRatioIdc) {
-          case 1: sarRatio = [1,1]; break;
-          case 2: sarRatio = [12,11]; break;
-          case 3: sarRatio = [10,11]; break;
-          case 4: sarRatio = [16,11]; break;
-          case 5: sarRatio = [40,33]; break;
-          case 6: sarRatio = [24,11]; break;
-          case 7: sarRatio = [20,11]; break;
-          case 8: sarRatio = [32,11]; break;
-          case 9: sarRatio = [80,33]; break;
-          case 10: sarRatio = [18,11]; break;
-          case 11: sarRatio = [15,11]; break;
-          case 12: sarRatio = [64,33]; break;
-          case 13: sarRatio = [160,99]; break;
-          case 14: sarRatio = [4,3]; break;
-          case 15: sarRatio = [3,2]; break;
-          case 16: sarRatio = [2,1]; break;
+          case 1: sarRatio = [1, 1]; break;
+          case 2: sarRatio = [12, 11]; break;
+          case 3: sarRatio = [10, 11]; break;
+          case 4: sarRatio = [16, 11]; break;
+          case 5: sarRatio = [40, 33]; break;
+          case 6: sarRatio = [24, 11]; break;
+          case 7: sarRatio = [20, 11]; break;
+          case 8: sarRatio = [32, 11]; break;
+          case 9: sarRatio = [80, 33]; break;
+          case 10: sarRatio = [18, 11]; break;
+          case 11: sarRatio = [15, 11]; break;
+          case 12: sarRatio = [64, 33]; break;
+          case 13: sarRatio = [160, 99]; break;
+          case 14: sarRatio = [4, 3]; break;
+          case 15: sarRatio = [3, 2]; break;
+          case 16: sarRatio = [2, 1]; break;
           case 255: {
             sarRatio = [expGolombDecoder.readUnsignedByte() << 8 |
                         expGolombDecoder.readUnsignedByte(),
@@ -406,5 +414,5 @@ H264Stream.prototype = new Stream();
 
 module.exports = {
   H264Stream: H264Stream,
-  NalByteStream: NalByteStream,
+  NalByteStream: NalByteStream
 };

lib/codecs/index.js

@@ -1,4 +1,4 @@
 module.exports = {
   adts: require('./adts'),
-  h264: require('./h264'),
+  h264: require('./h264')
 };

lib/flv/flv-tag.js

@@ -65,7 +65,7 @@ FlvTag = function(type, extraData) {
 
   this.keyFrame = false; // :Boolean
 
-  switch(type) {
+  switch (type) {
   case FlvTag.VIDEO_TAG:
     this.length = 16;
     // Start the buffer at 256k
@@ -80,7 +80,7 @@ FlvTag = function(type, extraData) {
     this.keyFrame = true;
     break;
   default:
-    throw("Error Unknown TagType");
+    throw new Error('Unknown FLV tag type');
   }
 
   this.bytes = new Uint8Array(bufferStartSize);
@@ -145,7 +145,7 @@ FlvTag = function(type, extraData) {
   this.startNalUnit = function() {
     // remember position and add 4 bytes
     if (adHoc > 0) {
-      throw new Error("Attempted to create new NAL wihout closing the old one");
+      throw new Error('Attempted to create new NAL wihout closing the old one');
     }
 
     // reserve 4 bytes for nal unit size
@@ -253,10 +253,12 @@ FlvTag = function(type, extraData) {
       dtsDelta, // :int
       len; // :int
 
-    switch(this.bytes[0]) {
+    switch (this.bytes[0]) {
       // Video Data
     case FlvTag.VIDEO_TAG:
-      this.bytes[11] = ((this.keyFrame || extraData) ? 0x10 : 0x20 ) | 0x07; // We only support AVC, 1 = key frame (for AVC, a seekable frame), 2 = inter frame (for AVC, a non-seekable frame)
+       // We only support AVC, 1 = key frame (for AVC, a seekable
+       // frame), 2 = inter frame (for AVC, a non-seekable frame)
+      this.bytes[11] = ((this.keyFrame || extraData) ? 0x10 : 0x20) | 0x07;
       this.bytes[12] = extraData ?  0x00 : 0x01;
 
       dtsDelta = this.pts - this.dts;