Improve non-hold key callouts

[andrewtavis]

Terms

• I have searched open and closed design issues
• I agree to follow Scribe-Android's Code of Conduct

Description

This issue is to improve the key callouts that pop up when a key is pressed. As of now the callouts don't cover the key when they're pressed, with the user generally not seeing this as their thumb is covering the key, but the behavior is not correct based on comparisons to system keyboards.

Ideally there would be a full callout that covers the key, which then would transition to the hold callout if the user is holding a key to select alternate characters.

Contribution

This issue is thus of low priority as of now, but could be worked on later when the callouts are being investigated further. Others are welcome to contribute!

[Linfye]

@andrewtavis Does this issue still exist? Could you explain in details, like a screenshot?:)

[andrewtavis]

Will send something along later, @Linfye, but yes it does! :)

[andrewtavis]

In looking at it, there are a lot of issues with this functionality at this point, @Linfye, and it would be great if you could take a look at it :)

All of this is activated by Show popup on keypress in the settings, or at least the base popup. You can see that in dark mode the key popup is not colored appropriately:

Beyond that is the original reason for this issue, which is that the callout there is a bit messy. It'd be great if the callout looks more like it does in the iOS app where it visually appears that the callout is coming from the key, not just hovering over it:

Beyond that, the hold key for alternate characters functionality seems to have been broken along the way, or isn't working well in dark mode. See the image below:

The above is me holding the A key, but then there's no background behind the options to make it clear that if I swipe I can select one of the alternate A characters.

Let me know if you'd have interest in looking into any of the above! We could start with one PR to fix the color of the base callout in dark mode and make the hold to select callout visible again, and then we could do another PR to improve the callout itself 😊 Feel free to indicate that you have interest, and from there you can get started and I'll assign you later 🚀

[Linfye]

Yes, I'd like to work on this. Thanks for your explaination. :)

[andrewtavis]

Nice, @Linfye! Let us know if you have any questions :)

[andrewtavis]

Do you want to work on a fix for the long hold accent character selection background now, @Linfye? So a fix for the following above where the optional characters have no background:

[Linfye]

Yes 😁