Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license tag to the top of all Kotlin files #282

Closed
2 tasks done
andrewtavis opened this issue Dec 30, 2024 · 8 comments
Closed
2 tasks done

Add license tag to the top of all Kotlin files #282

andrewtavis opened this issue Dec 30, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Issue

As Scribe-Android is a GPL-3.0 licensed project, we need to include the license tag at the top of each file in the repository. This isn't necessarily the easiest for files in formats like XML, but for Scribe-iOS we've decided to include the short license at the top of all .swift files. We should follow the same convention for Scribe-Android with Kotlin files :)

This is a great good first issue for someone wanting to help with Scribe-Android! ✨😊

@andrewtavis andrewtavis added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed labels Dec 30, 2024
mat-in added a commit to mat-in/Scribe-Android that referenced this issue Dec 30, 2024
@mat-in
Copy link
Contributor

mat-in commented Dec 30, 2024

Added license to all .kt files. Please ask if needed additional configurations.

@andrewtavis
Copy link
Member Author

andrewtavis commented Dec 30, 2024

See my message in the now closed PR, @mat-in :) Please let us know if you need some assistance!

@MostafaMohamed2002
Copy link
Contributor

is there any chance to assign this to me ?

@andrewtavis andrewtavis moved this from Todo to In Progress in Scribe Board Dec 31, 2024
@andrewtavis
Copy link
Member Author

#284 was opened for this, @MostafaMohamed2002 :) Feel free to let us know if there's another issue you'd like to work on! 😊

@MostafaMohamed2002
Copy link
Contributor

Oh , i didn't notice that there is a new pr already open 😔 , i think i can help with something else 😀

@andrewtavis
Copy link
Member Author

Looking forward, @MostafaMohamed2002! 🚀

@andrewtavis
Copy link
Member Author

Closed by #284 :) Thanks a lot for taking this on and getting it finished up in such a timely manner, @mat-in! Really great to have the codebase be more compliant with the license.

CC @angrezichatterbox: I did my best to edit the file descriptions at the top of the files, but ultimately you know best on these things. Maybe you could take a moment to check them and send a commit with edits to make them a bit more clear to what all the files are exactly doing?

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Dec 31, 2024
@angrezichatterbox
Copy link
Member

Closed by #284 :) Thanks a lot for taking this on and getting it finished up in such a timely manner, @mat-in! Really great to have the codebase be more compliant with the license.

CC @angrezichatterbox: I did my best to edit the file descriptions at the top of the files, but ultimately you know best on these things. Maybe you could take a moment to check them and send a commit with edits to make them a bit more clear to what all the files are exactly doing?

I will look into it and check if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

4 participants