Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Scribe-Data SQLite DBs #12

Open
2 tasks done
andrewtavis opened this issue Sep 4, 2024 · 6 comments
Open
2 tasks done

Integrate Scribe-Data SQLite DBs #12

andrewtavis opened this issue Sep 4, 2024 · 6 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

As discussed in #1, we need to include the SQLite databases that are present in Scribe-Data/scribe_data_sqlite_export. The goal of this issue would be to import these DBs into the project, but them in an appropriate location where they would be accessible by the rest of the app, and code a simple call to the databases. The call could be as simple as typing a word in the nouns table would then cause its gender or plural to then be inserted into the GUI's text :)

Contribution

Happy to check this and assist as needed! Questions for how this should work are welcome 😊

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Sep 4, 2024
@henrikth93
Copy link
Member

I am interested

@andrewtavis
Copy link
Member Author

@RyanPaulGannon, @henrikth93: One thing that we need to discuss here is where the data will live within the application. Specifically we will have a data directory like Scribe-Android. We also need to check the suggested structure of Rust projects in general and make sure that we're following best practices :)

@andrewtavis
Copy link
Member Author

We also need to remember to add the current version of the data contracts at that time :)

@henrikth93 henrikth93 self-assigned this Jan 15, 2025
@henrikth93
Copy link
Member

Terms

Description

As discussed in #1, we need to include the SQLite databases that are present in Scribe-Data/scribe_data_sqlite_export. The goal of this issue would be to import these DBs into the project, but them in an appropriate location where they would be accessible by the rest of the app, and code a simple call to the databases. The call could be as simple as typing a word in the nouns table would then cause its gender or plural to then be inserted into the GUI's text :)

Contribution

Happy to check this and assist as needed! Questions for how this should work are welcome 😊
https://github.com/scribe-org/Scribe-Data/tree/main/scribe_data_sqlite_export
That link does not seem to work.

@andrewtavis
Copy link
Member Author

Those have been deleted from Scribe-Data as the point is that it makes them, it doesn't have them. I'd copy over the DBs from Scribe-Android/tree/main/app/src/main/assets/data once we decide where they go :)

@andrewtavis
Copy link
Member Author

I think it's fine that we have the data in a scribe/src/data directory for now as we can just move it whenever, and this is what I saw as a suggestion in a few places :) Added them in in e1de03c, and by the looks of it testing/implementation of using these should leverage rusqlite/rusqlite 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants