Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the 100% rounding errors #187

Open
Cashmaney opened this issue May 3, 2021 · 0 comments
Open

Fix the 100% rounding errors #187

Cashmaney opened this issue May 3, 2021 · 0 comments
Labels
earn

Comments

@Cashmaney
Copy link
Member

The 100% bug still happens occasionally. This is a rounding error caused by dividing the balances before storing them (or while displaying) instead of storing them as BigNumbers and trimming as necessary. This one is a bit harder to fix, as it requires a deeper refactor, but it is a big source of user complaints/issues as it is not immediately apparent what went wrong.

An interim solution would be to maybe add some warning or info when clicking the 100% button?
@Cashmaney Cashmaney added the earn label May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
earn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Cashmaney