Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: selection #4

Open
chapmanjacobd opened this issue Jul 22, 2023 · 1 comment
Open

docs: selection #4

chapmanjacobd opened this issue Jul 22, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@chapmanjacobd
Copy link

What actions do not clear the selection afterwards?

Also, it would be useful to log the count of selected whenever the count of result is logged so that it might be more obvious when the selection is not cleared.

Count of selection seems like a more important thing to log than many of the other things that are logged by default. Sometimes logging too much can make it harder to see important stuff--though the colors definitely help

@scrubbbbs scrubbbbs added the enhancement New feature or request label Jul 22, 2023
@scrubbbbs
Copy link
Owner

-select-* appends to the current selection, except of course -select-none.

Anything that produces a result/group set should clear the selection, otherwise that's a bug. The reasoning is that when you have both a selection and result, some commands get ambiguous (e.g. when -show is used what do you see, the selection or result...).

The one exception I found was -nuke which clears it. In that case it makes sense since it invalidates the selection.

I think that logic is isn't too convoluted, but yes it should be documented. I've started the wiki so we can start listing out some of these things that are probably too detailed for a -help page.

Yes the logging is a big chaotic, I have mostly focused on logging something for anything that could take a long time, it bothers me a lot when there is a long pause with no logging.

I do have a small bug in my brain to removing extra logging or move it to the debug log when I come across it. Eventually the debug logging will be hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants