Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create service and CLI stub for fast vnodes restore. #4200

Open
karol-kokoszka opened this issue Jan 13, 2025 · 0 comments · Fixed by #4219
Open

Create service and CLI stub for fast vnodes restore. #4200

karol-kokoszka opened this issue Jan 13, 2025 · 0 comments · Fixed by #4219
Assignees
@VAveryanov8
Milestone
1-1 Restore

Comments

@karol-kokoszka
Copy link
Collaborator

The service can be located in /pkg/service/<new_restore_service_name> .

Tasks in Scylla Manager are started by the scheduler.

Every "task" service must implement Runner interface

scylla-manager/pkg/service/scheduler/runner.go

Line 17 in 68c99a6

type Runner interface {

that is used by the scheduler to trigger the task.

The stub must consist of the Runner implementation, constructor for the service accepting source-cluster-id, snapshot-id, nodes-mapping and the main method supervising the fast vnodes restore process.

The stub must be connected to the new CLI similar to (

scylla-manager/pkg/cmd/sctool/sctool.go

Line 65 in 61acf93

restoreCmd := restore.NewCommand(&client)
) allowing to trigger the 1-1 restore.

The goal of this task is to have working (but not final) CLI that schedules the 1-1 vnodes restore to start immediately. The main (supervising) restore method from the service stub can just log that "Not yet implemented".
@karol-kokoszka karol-kokoszka added this to the 1-1 Restore milestone Jan 13, 2025
@karol-kokoszka karol-kokoszka changed the title Create service and CLI stub for fast nodes restore. Create service and CLI stub for fast vnodes restore. Jan 13, 2025
VAveryanov8 added a commit that referenced this issue Jan 20, 2025
@VAveryanov8
feat(managerclient): adds new task type - fastrestore
d9a5fbf 
This adds a new task type for fast vnode restore.

Fixes: #4200
@VAveryanov8 VAveryanov8 mentioned this issue Jan 20, 2025
Merged
VAveryanov8 added a commit that referenced this issue Jan 20, 2025
@VAveryanov8
feat(fastrestore cli): adds new fastrestore cli to sctool
b41cfbe 
This introduces new cli command for fast vnode restore procedure.

Fixes: #4200
VAveryanov8 added a commit that referenced this issue Jan 29, 2025
@VAveryanov8
feat(managerclient): adds new task type - fastrestore
b115ad5 
This adds a new task type for fast vnode restore.

Fixes: #4200
VAveryanov8 added a commit that referenced this issue Jan 29, 2025
@VAveryanov8
feat(fastrestore cli): adds new fastrestore cli to sctool
e7b9831 
This introduces new cli command for fast vnode restore procedure.

Fixes: #4200
VAveryanov8 added a commit that referenced this issue Feb 3, 2025
@VAveryanov8
feat(managerclient): adds new task type - 1_1_restore (#4219)
c0fcaa6 
This adds a new task type for fast vnode restore.

Relates: #4200
VAveryanov8 added a commit that referenced this issue Feb 7, 2025
@VAveryanov8
feat(1-1-restore): adds 1-1-restore cli and service stub (#4221)
890c37b 
* feat(1-1-restore): adds new 1-1-restore sub command

This introduces new cli sub command for the 1-1-restore

Relates: #4200
VAveryanov8 added a commit that referenced this issue Feb 7, 2025
@VAveryanov8
feat(fastrestore cli): adds new fastrestore cli to sctool
fb3f65b 
This introduces new cli command for fast vnode restore procedure.

Fixes: #4200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VAveryanov8 VAveryanov8

Labels
None yet
Projects
None yet
Milestone
1-1 Restore
Development

Successfully merging a pull request may close this issue.

feat(managerclient): adds new task type - 1_1_restore scylladb/scylla-manager
2 participants
@VAveryanov8 @karol-kokoszka