Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is impossible to benefit from managerclient.ListBackups #4227

Open
aberry-21 opened this issue Jan 23, 2025 · 2 comments · May be fixed by #4228
Open

It is impossible to benefit from managerclient.ListBackups #4227

aberry-21 opened this issue Jan 23, 2025 · 2 comments · May be fixed by #4228

Comments

@aberry-21
Copy link

It is not possible to retrieve a list of models.BackupListItem because it is private, which makes the method useless for managerclient users.

Image
aberry-21 pushed a commit to aberry-21/scylla-manager that referenced this issue Jan 23, 2025
aberry-21 pushed a commit to aberry-21/scylla-manager that referenced this issue Jan 23, 2025
@Michal-Leszczynski
Copy link
Collaborator

Hi!
For now we haven't yet decided on the destiny of managerclient module. It's not properly released yet.
It is basically a wrapper for swagger generated client in order to build sctool CLI.

We are deciding whether this module makes sense in general:

  • there shouldn't be a need for the user to access sctool related code
  • users can use swagger generated client from the swagger module

This module was created ad-hoc, so that other Scylla projects (cloud/operator) could start using it without worrying about the replace directive from the main module go.mod.

@aberry-21 what is your opinion on this matter?
What are you using the managerclient module for? Is using swagger generated managerclient enough for your needs?

@aberry-21
Copy link
Author

Hi @Michal-Leszczynski,
I thought that managerclient was the intended client for interacting with Scylla Manager. I believe I can switch to the Swagger-generated client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants