Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Toggle NAM on/off #431

Open
joakimkl3 opened this issue Jan 18, 2024 · 7 comments
Open

[FEATURE] Toggle NAM on/off #431

joakimkl3 opened this issue Jan 18, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request priority:low Low priority issues

Comments

@joakimkl3
Copy link

Many amp/stomp plugins have an on/off button that passes through a dry signal when turned off. This would be helpful when setting up midi controllers with some DAW and controller combos (e.g. M-VAVE Chocolate and Element).

@joakimkl3 joakimkl3 added enhancement New feature or request priority:low Low priority issues unread This issue is new and hasn't been seen by the maintainers yet labels Jan 18, 2024
@sdatkinson
Copy link
Owner

This is very nearly "below the line" for me, but if it can be implemented the same way that the IR toggle currently is, would that be sufficient?

@sdatkinson sdatkinson removed the unread This issue is new and hasn't been seen by the maintainers yet label Feb 5, 2024
@joakimkl3
Copy link
Author

That would be perfect. Then it would be possible to toggle the amp section using a program control (PC) midi event in Element in the same way as one can with the IR section. It would make the plugin complete ;)

@marmal95
Copy link

Hi,

I haven't contributed yet into NAM but I would be able to implement this feature if @sdatkinson would be willing to merge it.

@sdatkinson
Copy link
Owner

@marmal95 go for it!

@marmal95
Copy link

Sure, just a question about how it's supposed to work.

  1. Only NAM model is toggled (similarly to IR) - in such case, as I understand, EQ would be still applicable when enabled and IR.
  2. Whole plugin should be toggled (so e.g. by clicking on NAM logo we disable it completely).
  3. Both options

@joakimkl3
Copy link
Author

Based on the original description, I would say that the second option corresponds to the desired feature.

@marmal95
Copy link

PR created #494.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:low Low priority issues
Projects
None yet
Development

No branches or pull requests

3 participants