From 119177ec19da97749f86149cec2c1bdf5978c384 Mon Sep 17 00:00:00 2001
From: Stephen Early <steve@assorted.org.uk>
Date: Tue, 28 Jan 2025 09:48:44 +0000
Subject: [PATCH] Remove unnecessary explicit commits to the database

---
 quicktill/barcode.py | 6 ------
 quicktill/till.py    | 1 -
 quicktill/user.py    | 1 -
 3 files changed, 8 deletions(-)

diff --git a/quicktill/barcode.py b/quicktill/barcode.py
index a79635d..54fba22 100644
--- a/quicktill/barcode.py
+++ b/quicktill/barcode.py
@@ -171,7 +171,6 @@ def stockline(self, code):
     def _finish_stockline(self, code, stockline):
         binding = self._clear_binding(code)
         binding.stockline = stockline
-        td.s.commit()
         _barcode_change_confirmed(
             [f'Barcode {code} is now assigned to stock line "{stockline}".'])
 
@@ -183,7 +182,6 @@ def plu(self, code):
     def _finish_plu(self, code, plu):
         binding = self._clear_binding(code)
         binding.plu = plu
-        td.s.commit()
         _barcode_change_confirmed(
             [f'Barcode {code} is now assigned to price lookup "{plu}".'])
 
@@ -194,7 +192,6 @@ def stocktype(self, code):
     def _finish_stocktype(self, code, st):
         binding = self._clear_binding(code)
         binding.stocktype = st
-        td.s.commit()
         _barcode_change_confirmed(
             [f'Barcode {code} is now assigned to stock type "{st}".'])
 
@@ -204,7 +201,6 @@ def modifier(self, code):
     def _finish_modifier(self, code, m):
         binding = self._clear_binding(code)
         binding.modifier = m
-        td.s.commit()
         _barcode_change_confirmed(
             [f'Barcode {code} is now assigned to modifier "{m}".'])
 
@@ -217,7 +213,6 @@ def _finish_defmodifier(self, code, m):
         binding = b.binding
         if binding:
             binding.modifier = m
-            td.s.commit()
             _barcode_change_confirmed(
                 [f'Barcode {code} now has default modifier "{m}".'])
         else:
@@ -228,5 +223,4 @@ def remove(self, code):
         b = barcode(code)
         if b.binding:
             td.s.delete(b.binding)
-            td.s.commit()
         _barcode_change_confirmed([f"Barcode {code} has been removed."])
diff --git a/quicktill/till.py b/quicktill/till.py
index 69ed5c1..efb1b8b 100644
--- a/quicktill/till.py
+++ b/quicktill/till.py
@@ -280,7 +280,6 @@ def run(args):
             td.s.add(reg)
             td.s.flush()
             tillconfig.register_id = reg.id
-            td.s.commit()
 
         dbg_kbd = None
         try:
diff --git a/quicktill/user.py b/quicktill/user.py
index 4bb3db8..fa70e0f 100644
--- a/quicktill/user.py
+++ b/quicktill/user.py
@@ -679,7 +679,6 @@ def usersmenu():
 def reactivate_user(userid):
     u = td.s.get(User, userid)
     u.enabled = True
-    td.s.commit()
     ui.toast(f'User "{u.fullname}" reactivated.')
     log(f"Reactivated user {u.logref}")
     edituser(userid)