feat: Allow for not verifying SSL certificates for requests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many corporate networks use SSL decryption of requests for security purposes akin to a man in the middle attack. This decryption causes underlying frameworks to throw SSL exceptions. It would be nice to provide an option to allow users to disable certificate verification of requests.
|
I didn't see this till now, I will review and merge it this weekend |
|
Any updates on this PR? Alternatively if I could pass the requests session through for use that would also work, but probably be more complicated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many corporate networks use SSL decryption of requests for security purposes akin to a man in the middle attack. This decryption causes underlying frameworks to throw SSL exceptions. It would be nice to provide an option to allow users to disable certificate verification of requests.