Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have one write_properties() function #995

Open
lwjohnst86 opened this issue Jan 23, 2025 · 0 comments
Open

Have one write_properties() function #995

lwjohnst86 opened this issue Jan 23, 2025 · 0 comments

Comments

@lwjohnst86
Copy link
Member

lwjohnst86 commented Jan 23, 2025

Having looked at these functions a bit, maybe a natural organisation would be:

  • edit_package_properties (leave as is):
    • takes a partial PackageProperties
    • returns a complete PackageProperties, ready to write to file
  • edit_resource_properties (= most of the current write_resource_properties):
    • takes a partial ResourceProperties
    • returns a complete PackageProperties, ready to write to file
  • write_properties (= the current write_package_properties)
    • takes a complete PackageProperties

The big change here would be that edit_resource_properties would return a PackageProperties (with the ResourceProperties updated or added). This gives a nice flow, but I'm not sure if it's misleading?

Originally posted by @martonvago in #990 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant