upgrade tokio-tls and native-tls to 0.2 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC, there is also an issue filed already on the main repo serenity-rs/serenity#394 |
|
closing, very old |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm running into problems using serenity because my system's version of openssl is too new (see sfackler/rust-openssl#987 for a similar problem). This PR upgrades tokio-tls and native-tls (and transitively rust-openssl) to fix this issue.
The changes are just to migrate to the new
tokio_tls::{TlsAcceptor, TlsConnector}types and to use them where appropriate (only in a few async functions). The crate builds and the unit tests pass.