You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
on the next branch cache is no longer used on methods like to_user so http requests that could be avoided by using cache are no longer avoided. I believe access to the cache is still possible in these locations so checking the guild's cache where it makes sense should be done to potentially prevent a http request, if its not in cache the to_user method should be called (it will check temp_cache if enabled and then make a http request if its not found there either.
I am already addressing the docs change for the to_user method in #2809
I'm not sure if this is the case for other ArgumentConvert implementations but its worth noting that unnecessary api requests are being made when they could otherwise be avoided, it would be nice if those could be checked out too.
The text was updated successfully, but these errors were encountered:
on the next branch cache is no longer used on methods like
to_user
so http requests that could be avoided by using cache are no longer avoided. I believe access to the cache is still possible in these locations so checking the guild's cache where it makes sense should be done to potentially prevent a http request, if its not in cache theto_user
method should be called (it will check temp_cache if enabled and then make a http request if its not found there either.I am already addressing the docs change for the
to_user
method in #2809I'm not sure if this is the case for other ArgumentConvert implementations but its worth noting that unnecessary api requests are being made when they could otherwise be avoided, it would be nice if those could be checked out too.
The text was updated successfully, but these errors were encountered: