Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentConvert no longer uses cache due to usage of magic to_x methods #2835

Open
jamesbt365 opened this issue Apr 9, 2024 · 1 comment

Comments

@jamesbt365
Copy link
Member

on the next branch cache is no longer used on methods like to_user so http requests that could be avoided by using cache are no longer avoided. I believe access to the cache is still possible in these locations so checking the guild's cache where it makes sense should be done to potentially prevent a http request, if its not in cache the to_user method should be called (it will check temp_cache if enabled and then make a http request if its not found there either.

I am already addressing the docs change for the to_user method in #2809

I'm not sure if this is the case for other ArgumentConvert implementations but its worth noting that unnecessary api requests are being made when they could otherwise be avoided, it would be nice if those could be checked out too.

@GnomedDev
Copy link
Member

I feel like this should be fixed by killing ArgumentConvert on next, as part of the standard framework removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants