Skip to content
This repository has been archived by the owner on Apr 18, 2022. It is now read-only.

Nuget assembly does not have strong name #36

Open
sjlangleyCSGI opened this issue Dec 21, 2017 · 2 comments
Open

Nuget assembly does not have strong name #36

sjlangleyCSGI opened this issue Dec 21, 2017 · 2 comments

Comments

@sjlangleyCSGI
Copy link
Contributor

My project creates a signed assembly, so I can only reference signed assemblies. Core Serilog is signed, so we've had no trouble using it, but we can't pull in this sink without signing it ourselves. Why is that? Isn't this an official Serilog project?

@JustinThirkell
Copy link
Contributor

no this isn't an official serilog project.
we've not strongly signed the assembly because no one has had need to do so.

@sjlangleyCSGI
Copy link
Contributor Author

My mistake - that makes sense. I opened a PR to strongly sign:

#37

Please review, thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants