Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entitySet: do not ignore licenseId set by editor #1326

Open
elbotho opened this issue Mar 28, 2024 · 1 comment
Open

entitySet: do not ignore licenseId set by editor #1326

elbotho opened this issue Mar 28, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@elbotho
Copy link
Member

elbotho commented Mar 28, 2024

What is wrong?

Currently the API always uses the default license when creating new entities:
https://github.com/serlo/api.serlo.org/blob/staging/packages/server/src/schema/uuid/abstract-entity/entity-set-handler.ts#L151

How should it behave?

It would be nice if the API would use the licenseId set in the editor (in the serlo-template-plugins).

Proposed Solution

We need to parse the entity content (outermost plugin) and retrieve and use the licenseId if there is one. Otherwise falling back to default like before is fine.

@elbotho elbotho added bug Something isn't working good first issue Good for newcomers labels Mar 28, 2024
@elbotho
Copy link
Member Author

elbotho commented Apr 3, 2024

(serlo/frontend#3501)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant