From 07ec3a6dbeb20ae269fd46241cdaa50b7d4045e3 Mon Sep 17 00:00:00 2001 From: Entkenntnis Date: Tue, 30 Jan 2024 13:57:03 +0100 Subject: [PATCH 1/2] refactor(workfows): update to node 20 --- .github/workflows/e2e_tests.yaml | 8 ++--- .github/workflows/e2e_tests_firefox.yaml | 8 ++--- .github/workflows/editor.yaml | 2 +- .github/workflows/js.yaml | 36 ++++++++++---------- .github/workflows/nextjs_bundle_analysis.yml | 18 +++++----- .github/workflows/repo.yaml | 6 ++-- 6 files changed, 39 insertions(+), 39 deletions(-) diff --git a/.github/workflows/e2e_tests.yaml b/.github/workflows/e2e_tests.yaml index fecdce7208..3bd31ebb35 100644 --- a/.github/workflows/e2e_tests.yaml +++ b/.github/workflows/e2e_tests.yaml @@ -14,10 +14,10 @@ jobs: run: working-directory: ./e2e-tests steps: - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: - node-version: 18.x - - uses: actions/checkout@v3 + node-version: 20 + - uses: actions/checkout@v4 - run: yarn - run: yarn playwright install --with-deps chromium - uses: patrickedqvist/wait-for-vercel-preview@v1.3.1 @@ -26,7 +26,7 @@ jobs: max_timeout: 1200 check_interval: 20 - run: yarn e2e-workers - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: failure() with: name: e2e-screenshots-on-fail diff --git a/.github/workflows/e2e_tests_firefox.yaml b/.github/workflows/e2e_tests_firefox.yaml index 1789a1add6..24cad3bf83 100644 --- a/.github/workflows/e2e_tests_firefox.yaml +++ b/.github/workflows/e2e_tests_firefox.yaml @@ -14,10 +14,10 @@ jobs: run: working-directory: ./e2e-tests steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn playwright install --with-deps firefox - uses: patrickedqvist/wait-for-vercel-preview@v1.3.1 @@ -26,7 +26,7 @@ jobs: max_timeout: 1200 check_interval: 20 - run: yarn e2e-firefox tests/4*.ts - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 if: failure() with: name: e2e-screenshots-on-fail diff --git a/.github/workflows/editor.yaml b/.github/workflows/editor.yaml index ea5bb95aa1..8243ade975 100644 --- a/.github/workflows/editor.yaml +++ b/.github/workflows/editor.yaml @@ -13,7 +13,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 registry-url: https://registry.npmjs.org - run: yarn - run: yarn build:prisma diff --git a/.github/workflows/js.yaml b/.github/workflows/js.yaml index cabac2d0a4..933148b904 100644 --- a/.github/workflows/js.yaml +++ b/.github/workflows/js.yaml @@ -9,54 +9,54 @@ jobs: yarn: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn --check-cache eslint: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn build:prisma - run: yarn lint:eslint prettier: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn lint:prettier tsc: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn lint:tsc test: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn test api: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn check:api diff --git a/.github/workflows/nextjs_bundle_analysis.yml b/.github/workflows/nextjs_bundle_analysis.yml index bf96ef6bcb..9356bc5e6b 100644 --- a/.github/workflows/nextjs_bundle_analysis.yml +++ b/.github/workflows/nextjs_bundle_analysis.yml @@ -26,12 +26,12 @@ jobs: analyze: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Install Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Install dependencies uses: bahmutov/npm-install@v1 @@ -46,7 +46,7 @@ jobs: # run_install: true - name: Restore next build - uses: actions/cache@v3 + uses: actions/cache@v4 id: restore-build-cache env: cache-name: cache-next-build @@ -67,13 +67,13 @@ jobs: run: cd apps/web && npx -p nextjs-bundle-analysis report - name: Upload bundle - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: bundle path: apps/web/.next/analyze/__bundle_analysis.json - name: Download base branch bundle stats - uses: dawidd6/action-download-artifact@v2 + uses: dawidd6/action-download-artifact@v4 if: success() && github.event.number with: workflow: nextjs_bundle_analysis.yml @@ -107,7 +107,7 @@ jobs: echo EOF >> $GITHUB_OUTPUT - name: Find Comment - uses: peter-evans/find-comment@v2 + uses: peter-evans/find-comment@v3 if: success() && github.event.number id: fc with: @@ -115,14 +115,14 @@ jobs: body-includes: '' - name: Create Comment - uses: peter-evans/create-or-update-comment@v2 + uses: peter-evans/create-or-update-comment@v4 if: success() && github.event.number && steps.fc.outputs.comment-id == 0 with: issue-number: ${{ github.event.number }} body: ${{ steps.get-comment-body.outputs.body }} - name: Update Comment - uses: peter-evans/create-or-update-comment@v2 + uses: peter-evans/create-or-update-comment@v4 if: success() && github.event.number && steps.fc.outputs.comment-id != 0 with: issue-number: ${{ github.event.number }} diff --git a/.github/workflows/repo.yaml b/.github/workflows/repo.yaml index 28986eae05..2ae380332e 100644 --- a/.github/workflows/repo.yaml +++ b/.github/workflows/repo.yaml @@ -9,9 +9,9 @@ jobs: prettier: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-node@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-node@v4 with: - node-version: 18.x + node-version: 20 - run: yarn - run: yarn :prettier From e364077b38222e8a750c953fba8d887612cf9f5e Mon Sep 17 00:00:00 2001 From: Entkenntnis Date: Tue, 30 Jan 2024 13:58:45 +0100 Subject: [PATCH 2/2] fix(workflows): correct version --- .github/workflows/nextjs_bundle_analysis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nextjs_bundle_analysis.yml b/.github/workflows/nextjs_bundle_analysis.yml index 9356bc5e6b..94d082e716 100644 --- a/.github/workflows/nextjs_bundle_analysis.yml +++ b/.github/workflows/nextjs_bundle_analysis.yml @@ -73,7 +73,7 @@ jobs: path: apps/web/.next/analyze/__bundle_analysis.json - name: Download base branch bundle stats - uses: dawidd6/action-download-artifact@v4 + uses: dawidd6/action-download-artifact@v3 if: success() && github.event.number with: workflow: nextjs_bundle_analysis.yml