From b7141f6fccc95de3d601c912df5f47963eef048c Mon Sep 17 00:00:00 2001 From: Botho <1258870+elbotho@users.noreply.github.com> Date: Fri, 20 Dec 2024 17:12:00 +0100 Subject: [PATCH] fix(e2e): adapt test --- e2e-tests/tests/430-multimedia-plugin.ts | 4 +--- e2e-tests/tests/431-multimedia-plugin-image.ts | 12 +++--------- .../video/components/video-selection-screen.tsx | 2 +- 3 files changed, 5 insertions(+), 13 deletions(-) diff --git a/e2e-tests/tests/430-multimedia-plugin.ts b/e2e-tests/tests/430-multimedia-plugin.ts index 22e66be5e6..4afe3b1a56 100644 --- a/e2e-tests/tests/430-multimedia-plugin.ts +++ b/e2e-tests/tests/430-multimedia-plugin.ts @@ -49,9 +49,7 @@ Scenario('Multimedia plugin toolbar controls', async ({ I }) => { I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Video') I.click('$modal-close-button') - I.seeElement( - locate('$plugin-video-placeholder').inside('$plugin-multimedia-wrapper') - ) + I.seeElement(locate('$plugin-video-src').inside('$plugin-multimedia-wrapper')) I.say('Change the type of the multimedia content to GeoGebra') I.click('$plugin-multimedia-settings-button') diff --git a/e2e-tests/tests/431-multimedia-plugin-image.ts b/e2e-tests/tests/431-multimedia-plugin-image.ts index c82f43544a..6767abf7c3 100644 --- a/e2e-tests/tests/431-multimedia-plugin-image.ts +++ b/e2e-tests/tests/431-multimedia-plugin-image.ts @@ -54,9 +54,7 @@ Scenario('Multimedia plugin successful image upload', ({ I }) => { I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Video') I.click('$modal-close-button') - I.seeElement( - locate('$plugin-video-placeholder').inside('$plugin-multimedia-wrapper') - ) + I.seeElement(locate('$plugin-video-src').inside('$plugin-multimedia-wrapper')) I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Bild') I.click('$modal-close-button') @@ -111,9 +109,7 @@ Scenario('Multimedia plugin valid image URL', ({ I }) => { I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Video') I.click('$modal-close-button') - I.seeElement( - locate('$plugin-video-placeholder').inside('$plugin-multimedia-wrapper') - ) + I.seeElement(locate('$plugin-video-src').inside('$plugin-multimedia-wrapper')) I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Bild') I.click('$modal-close-button') @@ -148,9 +144,7 @@ Scenario('Multimedia plugin fill in image caption', ({ I }) => { I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Video') I.click('$modal-close-button') - I.seeElement( - locate('$plugin-video-placeholder').inside('$plugin-multimedia-wrapper') - ) + I.seeElement(locate('$plugin-video-src').inside('$plugin-multimedia-wrapper')) I.click('$plugin-multimedia-settings-button') I.selectOption('$plugin-multimedia-type-select', 'Bild') I.click('$modal-close-button') diff --git a/packages/editor/src/plugins/video/components/video-selection-screen.tsx b/packages/editor/src/plugins/video/components/video-selection-screen.tsx index 6e8a4d1791..e49f92c90c 100644 --- a/packages/editor/src/plugins/video/components/video-selection-screen.tsx +++ b/packages/editor/src/plugins/video/components/video-selection-screen.tsx @@ -57,7 +57,7 @@ export function VideoSelectionScreen({ 'w-full rounded-lg border-0 bg-yellow-100 px-4 py-2 text-gray-600', showErrorMessage && 'outline outline-1 outline-red-500' )} - data-qa="plugin-image-src" + data-qa="plugin-video-src" /> {showErrorMessage && ( <>