-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editor(plugin-video): allow native html5 video media types #4059
Comments
Thank you @oellers for your super thorough suggestion! We will talk about it next week and get back to you. |
Thank you @oellers for the issue + PR. It shows that integrating video files will be easy to implement. Currently we are planning a new plugin for interactive videos (see https://2024-09-06-demo-interactive-video.vercel.app/). For this we need to change our video player anyways since we will need one which support chapter markers (do you know one)? Then we plan to work on this issue as well and to add support for native html5 video files. |
Also a quick question @oellers: Do you have examples / use cases where those files would be hosted? |
Like WebVTT chapters? You might also want to inspire yourself from our list of video annotation tools, e.g. in terms of features, that we gathered in the Opencast Annotation Tool Community Meetings.
Literally anywhere (if this will be a generalized feature), that's kind of the challenge of validation here, unless you want to introduce some kind of custom allowlists for deployments; Examples: Edit: If you change the player, I'd actually would love to see HLS/DASH-Streaming as well =) |
Unfortunately due to privacy constrains we basically have to. |
Current state
Goal
Draft
Discussion (UX)
How can remote media types be validated?
Extension validation (soft validation)
Url indicates a typical media extension type (e.g. .mp4, .webm, .ogg for html5 video elements).
Disadvantages:
workarounds by suffixing with a valid media type, e.g. in the query parameter (bad ux)
Header validation
Retrieve the content-type response header from the URL.
A (cors) request to get the headers of the URL could be initiated.
Disadvantages:
How do others deal with this situation?
H5P
\.(\w+)$
within the html5 videourl.match(/\.(webm|mp4|ogv|m4a|mp3|ogg|oga|wav)/i);
within the h5p editorConclusion
MEDIA_ERR_SRC_NOT_SUPPORTED
if source is not supportedFollow up question
What are the opinions of the Serlo maintainers on that matter? I could prepare a PR based on the decision.
The text was updated successfully, but these errors were encountered: