Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Write body of releases from our generated changelog #4186

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

CodingDive
Copy link
Contributor

@CodingDive CodingDive commented Oct 11, 2024

Our plugin from the market place did not allow me to write the body of the release. Therefore, the first release here contains the default release notes (a summary of all PRs in the frontend repo), instead of only the ones of the editor package that we care about.

https://github.com/serlo/frontend/releases/tag/v0.16.0

I took inspiration from it and changed it, so that the changelog will thank the authors, link to the pull request and also summarize all changes/commits in the code.

I then changed the editor.yaml to use curl so that we can POST the body of the release notes to the github endpoint. Docs https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#create-a-release

Mikey Stengel added 2 commits October 11, 2024 16:29
…d stop using a custom action to make releases (can't write the body)
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Oct 11, 2024 2:35pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 104.55 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@CodingDive CodingDive changed the title Ci/write body of releases ci: Write body of releases from our generated changelog Oct 11, 2024
@hugotiburtino hugotiburtino merged commit 9301313 into staging Oct 14, 2024
9 checks passed
@hugotiburtino hugotiburtino deleted the ci/write-body-of-releases branch October 14, 2024 12:13
@github-actions github-actions bot mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants