Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): package plugin icons as react components (to remove dangerouslySetInnerHtml) #4370

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

LarsTheGlidingSquirrel
Copy link
Member

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel commented Dec 19, 2024

Not super clean because SVGs are duplicated now. Either as react component or as string that is exported in the package. But if we do not change them often it should be fine.

And bundle size increase.

There are probably better solutions.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 19, 2024 6:19pm

Copy link
Contributor

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 655.54 KB (🟡 +12.4 KB) 760.4 KB
/entity/create/[type]/[taxonomyId] 675.81 KB (🟡 +12.4 KB) 780.68 KB
/entity/repository/add-revision/[...id] 675.55 KB (🟡 +12.4 KB) 780.42 KB
/page/create 675.54 KB (🟡 +12.4 KB) 780.4 KB
/taxonomy/term/create/[parent_id]/[id] 675.28 KB (🟡 +12.4 KB) 780.15 KB
/taxonomy/term/update/[id] 675.23 KB (🟡 +12.4 KB) 780.1 KB
/user/settings 677.2 KB (🟡 +12.4 KB) 782.07 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@LarsTheGlidingSquirrel LarsTheGlidingSquirrel merged commit ac642fa into staging Dec 20, 2024
9 checks passed
@LarsTheGlidingSquirrel LarsTheGlidingSquirrel deleted the plugin-icons-as-react-components branch December 20, 2024 05:48
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants