Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the standard opcode value read for hint_ram_based #1224

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Use the standard opcode value read for hint_ram_based #1224

merged 1 commit into from
Dec 26, 2023

Conversation

paulfd
Copy link
Member

@paulfd paulfd commented Dec 26, 2023 •
edited
Loading

@redtide
Closes: #1187

@redtide
Copy link
Member

redtide commented Dec 26, 2023

Thank you!

@paulfd paulfd merged commit 5a51e0b into develop Dec 26, 2023
11 checks passed
@paulfd paulfd deleted the paulfd/issue-1187 branch December 26, 2023 15:25
@Sylv1o
Copy link

Sylv1o commented Jan 6, 2024

Hi, does it change something in the syntaxe to be used ?
hint_ram_based=1 still OK ?

Thanks

@redtide
Copy link
Member

redtide commented Jan 6, 2024 •
edited
Loading

@Sylv1o: It's OK. Before this hint_ram_based used only integer ARIA style boolean, now should use readBoolean like other boolean opcodes, that supports also CakeWalk' "on/off" (for consistence).

@Sylv1o
Copy link

Sylv1o commented Jan 6, 2024

Great, thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hint_ram_based boolean?
4 participants
@paulfd @redtide @Sylv1o @pferrand-soundhound