Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: added build timeout #1238

Merged
merged 1 commit into from
Feb 8, 2024
Merged

CI: added build timeout #1238

merged 1 commit into from
Feb 8, 2024

Conversation

redtide
Copy link
Member

@redtide redtide commented Feb 8, 2024

10 minutes as default, 15 for macOS and Windows, 2 for source code package
@KKQ-KKQ
Copy link
Contributor

KKQ-KKQ commented Feb 8, 2024

Thanks you. but I don't know whether it's correct or not. Where can we check the actual timeout?

I thought abseil had issues but the tests succeeded.
I was wrong....

@redtide
Copy link
Member Author

redtide commented Feb 8, 2024

Where can we check the actual timeout?

Doing some average of previous build timings I guess, but this can be something we can manage later, hope these ones are good enough for now.

I thought abseil had issues but the tests succeeded.
I was wrong....

No worries, this can happen again in other contexts so it's good to have anyway.
I wait a bit for Paul before merging, have you found some way meanwhile to get it build with new Abseil?

@KKQ-KKQ
Copy link
Contributor

KKQ-KKQ commented Feb 8, 2024

With the following script on my mac, some tests fail on Abseil 20240116.rc1.
The tests don't fail on Abseil 20230125.3.

#!/bin/bash
BT=RelWithDebInfo
cmake -B build -S . -D SFIZZ_ASAN=ON -D CMAKE_BUILD_TYPE=${BT} -D SIZZ_SHARED=ON -D SFIZZ_TESTS=ON  &&\
cmake --build build --parallel 4 --target sfizz_tests --config ${BT} &&\
ctest --output-on-failure --stop-on-failure --test-dir build --build-config ${BT}

@redtide
Copy link
Member Author

redtide commented Feb 8, 2024

Oh, I didn't know we used release candidate versions other than LTS, so at this point maybe it worth to try the current 20240116.0 of 2 weeks ago maybe?

@redtide redtide merged commit 0ca5a6c into sfztools:develop Feb 8, 2024
11 checks passed
@redtide redtide deleted the ci-timeout branch February 8, 2024 20:23
@KKQ-KKQ
Copy link
Contributor

KKQ-KKQ commented Feb 8, 2024

Issue #1240
20240116.0 also fails.
20230802.1 works.
20230802.rc2 also works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants