Fix for possible ADSR hangs #1245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix applied to the CC processing: too many CC values were specified to be per-voice originally.
Merged changes in the fork and the main repo
-Corrected the eg_shapes -added support for eg_curvecc's.
This commit for a special branch is after discovering a glitch that I was even able to reproduce in the official builds: sometimes with the delay opcodes set to a value above zero, I noticed some notes would hang when getting close to the polyphony limit. Easiest way to reproduce is to hit a variety of notes very quickly across multiple octaves and velocities. You don't have to go that far to have the problem, but that's the guaranteed way to find it. Anyway, I hesitate to believe this revision is the way it should be for the ADSREnvelope source code, but I failed to reproduce it since: adding an extra iteration of the Delay phase of the envelope seems to negate the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit for a special branch in my fork is after discovering a glitch that I was even able to reproduce in the official builds: sometimes with the delay opcodes set to a value above zero, I noticed some notes would hang when getting close to the polyphony limit. Easiest way to reproduce is to hit a variety of notes very quickly across multiple octaves and velocities. You don't have to go that far to have the problem, but that's the guaranteed way to find it.
Anyway, I hesitate to believe this revision is the way it should be for the ADSREnvelope source code, but I failed to reproduce it since: adding an extra iteration of the Delay phase of the envelope seems to negate the problem.
Disregard the modified wavpack submodule if need be: not sure how that happened...