Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undocumented return values from passwd #1219

Closed
Zugschlus opened this issue Feb 19, 2025 · 0 comments · Fixed by #1244
Closed

undocumented return values from passwd #1219

Zugschlus opened this issue Feb 19, 2025 · 0 comments · Fixed by #1244

Comments

@Zugschlus
Copy link

Hi!

passwd returns exit code 10 which is not defined in the manual page.

[2/5164]mh@swivel:~ $ passwd
Changing password for mh.
Current password:
passwd: Authentication token manipulation error
passwd: password unchanged
10 [3/5165]mh@swivel:~ $ passwd
Changing password for mh.
Current password:
New password:
Retype new password:
Sorry, passwords do not match.
passwd: Authentication token manipulation error
passwd: password unchanged
10 [4/5165]mh@swivel:~ $

passwd(1) only documens exit codes 1 through 6.

Please also consider giving distinct exit codes for "current password entered wrong" and "password repeat doesnt match".

Greetings
Marc
hallyn added a commit to hallyn/shadow that referenced this issue Mar 22, 2025
@hallyn
passwd: document exit code when PAM has errored
bf27417 
closes shadow-maint#1219

When pam returns an error, we were exiting with exit code 10,
which was hardcoded and not documented.  Create a name for it,
and document it in the manpage.

Signed-off-by: Serge Hallyn <[email protected]>
Reported-by: Marc Haber <[email protected]>
@hallyn hallyn mentioned this issue Mar 22, 2025
Merged
hallyn added a commit to hallyn/shadow that referenced this issue Mar 24, 2025
@hallyn
passwd: document exit code when PAM has errored
741597a 
closes shadow-maint#1219

When pam returns an error, we were exiting with exit code 10,
which was hardcoded and not documented.  Create a name for it,
and document it in the manpage.

Signed-off-by: Serge Hallyn <[email protected]>
Reported-by: Marc Haber <[email protected]>
Reviewed-by: Alejandro Colomar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

passwd: document exit code when PAM has errored hallyn/shadow
1 participant
@Zugschlus