Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to detect mimeType from non-gap segments change #8032

Closed
yyamaguchi93 opened this issue Feb 7, 2025 · 2 comments
Closed

Unable to detect mimeType from non-gap segments change #8032

yyamaguchi93 opened this issue Feb 7, 2025 · 2 comments
Labels
type: bug Something isn't working correctly
Milestone

Comments

@yyamaguchi93
Copy link

Re-opening unresolved bug that was archived: #7119

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

If the question is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?
4.10.9

What browser and OS are you using?
Chrome on iOS

Please ask your question
I am trying to play a HLS manifest where the segment URIs on it does not have a extension, which makes shaka to try to retrieve the segment basic info from the segment request content-type header. In my case, this will return application/octet-stream. When that happens, none of the conditions regarding mimeType and extension will be satisfied and shaka will return a basic info where the type will be application/octet-stream back to convertParsedPlaylistIntoStreamInfo_ method. Shaka will then call makeStreamObject_ passing application/octet-stream as the type and, within makeStreamObject_ method, shaka will call guessMimeTypeFallback_ which will throw an error TypeError: Cannot read properties of undefined (reading 'get') because shaka.hls.HlsParser.EXTENSION_MAP_BY_CONTENT_TYPE_[contentType] map does not have an entry to application/octet-stream.

This issue does not happen on 4.9.x versions.
4.9.x versions will use mime type set in HlsManifestConfiguration.mediaPlaylistFullMimeType instead of throwing an error.

@yyamaguchi93 yyamaguchi93 added the type: bug Something isn't working correctly label Feb 7, 2025
@shaka-bot shaka-bot added this to the v4.14 milestone Feb 7, 2025
@avelad
Copy link
Member

avelad commented Feb 7, 2025

We need the following information in order to help you.

**What are the manifest and license server URIs?**
<!-- NOTE:
  You can send the URIs to <[email protected]> instead,
  but please use GitHub and the template for the rest.
  A copy of the manifest text or an attached manifest will **not** be
  enough to reproduce your issue, and we **will** ask you to send a
  URI instead.  You can copy the URI of the demo app to send us the
  exact asset, licence server, and settings you have selected there.
  Avoid geo-blocked content if at all possible, as the contributors who diagnose
  Shaka Player issues may not be able to access it.
  If you send the URIs to email, the response time and resolution
  will be much higher.
-->

@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 7, 2025
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants