Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH Clearkey doesn't work after 4.6.18 #8052

Closed
dbaer2002 opened this issue Feb 10, 2025 · 2 comments · Fixed by #8055
Closed

DASH Clearkey doesn't work after 4.6.18 #8052

dbaer2002 opened this issue Feb 10, 2025 · 2 comments · Fixed by #8055
Assignees
Labels
component: ClearKey The issue involves the ClearKey DRM priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Milestone

Comments

@dbaer2002
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes.

If the problem is related to FairPlay, have you read the tutorial?

Not applicable.

What version of Shaka Player are you using?

4.13.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Custom app

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Chrome on Windows

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?

https://a61avoddashs3ww-a.akamaihd.net/d/2$jONCCMxPydzaSl3Clj2M07yX3s0/ondemand/iad_2/65bf/fd35/0840/4140-b6a7-e7afce2639d6/2bfdfe99-4ee2-46fb-8a75-b5022bc8f74d_corrected.mpd?encoding=segmentBase
2b9f95f1b74e4103abf139404d6dc262:8b0895fe9b8129d1e618a80ab03d3804

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

 {
    drm: {
        clearKeys: "2b9f95f1b74e4103abf139404d6dc262": "8b0895fe9b8129d1e618a80ab03d3804",
    },
    streaming: {
        startAtSegmentBoundary: false,
    },
    manifest: {
        dash: {
            ignoreSuggestedPresentationDelay: true,
            ignoreMinBufferTime: true,
        },
        defaultPresentationDelay: 8,
    },
}

What did you do?

  1. Specify clearKeys for a DASH manifest in the DRM config
  2. Load the MPD and attempt playback

Playback succeeds on 4.6.18 but fails on any newer version.

What did you expect to happen?
Normal video playback

What actually happened?

The manifest loads but the video does not play.

Are you planning to send a PR to fix it?
Honestly not sure where to start here to fix it, so no.

@dbaer2002 dbaer2002 added the type: bug Something isn't working correctly label Feb 10, 2025
@dbaer2002
Copy link
Author

@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: ClearKey The issue involves the ClearKey DRM labels Feb 10, 2025
@avelad avelad self-assigned this Feb 10, 2025
@avelad avelad added this to the v4.14 milestone Feb 10, 2025
@avelad
Copy link
Member

avelad commented Feb 10, 2025

If I use disableAudio everything works fine, if I use disableVideo the problem occurs.

@avelad avelad assigned tykus160 and unassigned avelad Feb 11, 2025
avelad pushed a commit that referenced this issue Feb 17, 2025
#8055)

Fixes #8052
Key ids were not used when looking for stream duplicates, so it was
possible to filter out streams without accompanying configuration. Now
we will use key ids as well for duplicates detection.
avelad pushed a commit that referenced this issue Feb 17, 2025
#8055)

Fixes #8052
Key ids were not used when looking for stream duplicates, so it was
possible to filter out streams without accompanying configuration. Now
we will use key ids as well for duplicates detection.
joeyparrish pushed a commit that referenced this issue Feb 22, 2025
#8055)

Fixes #8052
Key ids were not used when looking for stream duplicates, so it was
possible to filter out streams without accompanying configuration. Now
we will use key ids as well for duplicates detection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ClearKey The issue involves the ClearKey DRM priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
3 participants