Touch event to display UI controls is incorrect?

[MarianoFacundoArch]

Hello all,
I think the touch control we are using to open the UI controls is not correct.
Currently, this is the related code:

    this.eventManager_.listen(this.controlsContainer_, 'touchstart', (e) => {
      this.onContainerTouch_(e);
    }, {passive: false});

  onContainerTouch_(event) {
    if (!this.video_.duration) {
      // Can't play yet.  Ignore.
      return;
    }

    if (this.isOpaque()) {
      this.lastTouchEventTime_ = Date.now();
      // The controls are showing.
      // Let this event continue and become a click.
    } else {
      // The controls are hidden, so show them.
      this.onMouseMove_(event);
      // Stop this event from becoming a click event.
      event.cancelable && event.preventDefault();
    }
  }

The problem with this code is that, if we are loading the player inside an iframe and we are on a phone, when we start the scrolling in the player, the scroll never happens; instead, it gets prevented and the UI controls are displayed instead. However, once the UI controls are visible, we are enabled to scroll.

Shouldn't this be changed accordingly to fix this weird behavior?

[avelad]

@theodab can you review it? Thanks!

[MarianoFacundoArch]

Maybe the correct event would be on touch end instead of start?

[avelad]

Maybe yes, @joeyparrish do you have any opinion about it?

[MarianoFacundoArch]

Great!
When shall this be released in a version?